You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sarahgoldman <gi...@git.apache.org> on 2015/08/26 21:49:35 UTC
[GitHub] cordova-plugin-camera pull request: Manual dismissal method for iO...
GitHub user sarahgoldman opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/117
Manual dismissal method for iOS
I have added a new function called `dismiss` that allows one to dismiss any camera popover views and view controllers on iOS. I encountered a need for this function when implementing a timeout based logout on my app. If the user timed out while sitting there with the camera open, I had no way to close the camera view controller and it would stay open on top of the login page. When they finally took a photo it would exit the camera and they would be on the login page. Now I can call `navigator.camera.dismiss()` before I go to the login view.
`dismiss` does not take any callback handlers, instead it triggers the error callback set with `getPicture` and sends a message stating the camera was dismissed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarahgoldman/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit e906e2d30a4e67baace039c556af6f55b16a288b
Author: Sarah Goldman <sa...@gmail.com>
Date: 2015-08-26T18:49:10Z
added dismiss function for ios camera popover and view controller
commit 4f915e87544f586e4140739cb9e28591d40fd4ea
Author: Sarah Goldman <sa...@gmail.com>
Date: 2015-08-26T19:19:00Z
removed cordova.define statement, not sure how this got added since I didn't add it the first time
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: Apple tvOS
Posted by julio cesar sanchez <jc...@gmail.com>.
I got one too, but the UIWebView is prohibited to use on tvOS, so not much
cordova testing to do on it :(
2015-10-19 13:19 GMT+02:00 Tammo Schimanski <ta...@cordova.de>:
> Hey Guys,
> i just want to let you know that i got an apple tv dev kit from apple just
> 3 weeks ago. If someone needs to test something or need some information,
> please let me know.
>
> Greetings from Germany,
> Tammo
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Apple tvOS
Posted by Tammo Schimanski <ta...@cordova.de>.
Hey Guys,
i just want to let you know that i got an apple tv dev kit from apple just 3 weeks ago. If someone needs to test something or need some information, please let me know.
Greetings from Germany,
Tammo
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Manual dismissal method for iO...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/117#issuecomment-149187339
@sarahgoldman, ping. Do you plan to finalize this? This might be a useful feature in some situations, but we need some steps to be completed first:
* As @jcesarmobile noticed, you need to create a JIRA for this feature. Also you'll probably need to get a community approval before proceed with this. You can send your proposal to dev@cordova.apache.org.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Manual dismissal method for iO...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/117#issuecomment-135329615
I think, everything you put after [self.pickerController dismissViewControllerAnimated:NO completion:nil]; should be on the completion block instead
Anyway, there should be an issue created for this before it gets merged, open it as "New feature" on http://issues.cordova.io/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Manual dismissal method for iO...
Posted by sarahgoldman <gi...@git.apache.org>.
Github user sarahgoldman commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/117#issuecomment-155885595
I have created a Jira issue here: https://issues.apache.org/jira/browse/CB-9980
I have also emailed dev@cordova.apache.org with the proposal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Manual dismissal method for iO...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/117#issuecomment-160819349
The dev list thread is [here](http://markmail.org/message/6jjxas3wrhwl6zb5). Looks like there is approval for this feature. @sarahgoldman I don't see your name in the [ICLA list](https://people.apache.org/committer-index.html#unlistedclas). You'll need to sign one (and potentially a CCLA) for this to be merged in. There are instructions for submitting an ICLA [here](http://cordova.apache.org/contribute/contribute_guidelines.html).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org