You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sunitha Beeram via Review Board <no...@reviews.apache.org> on 2017/06/06 23:20:03 UTC

Review Request 59867: HIVE-16831: Add unit tests for NPE fixes in HIVE-12054

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59867/
-----------------------------------------------------------

Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti.


Bugs: HIVE-16831
    https://issues.apache.org/jira/browse/HIVE-16831


Repository: hive-git


Description
-------

HIVE-16831: Add unit tests for NPE fixes in HIVE-12054


Diffs
-----

  ql/src/test/queries/clientpositive/orc_empty_table.q PRE-CREATION 
  ql/src/test/results/clientpositive/orc_empty_table.q.out PRE-CREATION 


Diff: https://reviews.apache.org/r/59867/diff/1/


Testing
-------

qtests pass.


Thanks,

Sunitha Beeram


Re: Review Request 59867: HIVE-16831: Add unit tests for NPE fixes in HIVE-12054

Posted by Anthony Hsu via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59867/#review177223
-----------------------------------------------------------


Ship it!




Looks good to me!

- Anthony Hsu


On 六月 6, 2017, 11:20 p.m., Sunitha Beeram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59867/
> -----------------------------------------------------------
> 
> (Updated 六月 6, 2017, 11:20 p.m.)
> 
> 
> Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti.
> 
> 
> Bugs: HIVE-16831
>     https://issues.apache.org/jira/browse/HIVE-16831
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16831: Add unit tests for NPE fixes in HIVE-12054
> 
> 
> Diffs
> -----
> 
>   ql/src/test/queries/clientpositive/orc_empty_table.q PRE-CREATION 
>   ql/src/test/results/clientpositive/orc_empty_table.q.out PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59867/diff/1/
> 
> 
> Testing
> -------
> 
> qtests pass.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>