You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/18 06:54:32 UTC

[GitHub] [airflow] Jorricks commented on a diff in pull request #26457: WIP Add user comment to task instance and dag run

Jorricks commented on code in PR #26457:
URL: https://github.com/apache/airflow/pull/26457#discussion_r973670428


##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -585,6 +585,41 @@ paths:
         '404':
           $ref: '#/components/responses/NotFound'
 
+  /dags/{dag_id}/setTaskInstanceNote:

Review Comment:
   Indeed, should have made this a PATCH operation.
   However, this ties in closer with a DAGRun than a DAG in general IMO.
   Shall I make it part of the already existing patch operation in `/dags/{dag_id}/dagRuns/{dag_run_id}:`?
   https://github.com/apache/airflow/blob/527c90c9804ee66cfa800381cbd67280e5d3a8a9/airflow/api_connexion/openapi/v1.yaml#L787



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org