[GitHub] [spark] viirya commented on a change in pull request #24654: [SPARK-27439][SQL] Explainging Dataset should show correct resolved plans

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #24654: [SPARK-27439][SQL] Explainging Dataset should show correct resolved plans
URL: https://github.com/apache/spark/pull/24654#discussion_r286031563
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
 ##########
 @@ -498,12 +500,25 @@ class Dataset[T] private[sql](
    * @since 1.6.0
    */
   def explain(extended: Boolean): Unit = {
-    val explain = ExplainCommand(queryExecution.logical, extended = extended)
-    sparkSession.sessionState.executePlan(explain).executedPlan.executeCollect().foreach {
-      // scalastyle:off println
-      r => println(r.getString(0))
-      // scalastyle:on println
+    val qe = if (isStreaming) {
 
 Review comment:
   Added comments and put common code into a method. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org