[GitHub] [spark] JkSelf commented on a change in pull request #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default

[GitBox <gi...@apache.org>]

JkSelf commented on a change in pull request #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default
URL: https://github.com/apache/spark/pull/26813#discussion_r362134017
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala
 ##########
 @@ -79,13 +80,20 @@ class CacheManager extends Logging {
       logWarning("Asked to cache already cached data.")
     } else {
       val sparkSession = query.sparkSession
-      val qe = sparkSession.sessionState.executePlan(planToCache)
-      val inMemoryRelation = InMemoryRelation(
-        sparkSession.sessionState.conf.useCompression,
-        sparkSession.sessionState.conf.columnBatchSize, storageLevel,
-        qe.executedPlan,
-        tableName,
-        optimizedPlan = qe.optimizedPlan)
+      val originalValue = sparkSession.sessionState.conf.getConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED)
+      val inMemoryRelation = try {
 
 Review comment:
   Here we need put `inMemoryRelation `in `try `not  `qe`. Because only when executing `qe.executedPlan`, it will be inserted `AdaptiveSparkPlanExec`. And I will remove the `qe `before `try` later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org