You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Daniel Naber (JIRA)" <ji...@apache.org> on 2007/05/17 23:33:16 UTC
[jira] Created: (LUCENE-883) make spell checker test case work
again
make spell checker test case work again
---------------------------------------
Key: LUCENE-883
URL: https://issues.apache.org/jira/browse/LUCENE-883
Project: Lucene - Java
Issue Type: Bug
Affects Versions: 2.1
Reporter: Daniel Naber
Attachments: lucene-spellchecker-2.diff
See attached path which makes the spellchecker test case work again. The problem without the patch is that consecutive calls to indexDictionary() will create a spelling index with duplicate words. Does anybody see a problem with this patch? I see that the spellchecker code is now used in Solr, isn't it? I didn't have time to test this patch inside Solr.
Also see http://issues.apache.org/jira/browse/LUCENE-632, but the null check is included in this patch so the NPE described there cannot happen anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-883) make spell checker test case work
again
Posted by "Daniel Naber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497014 ]
Daniel Naber commented on LUCENE-883:
-------------------------------------
Yes, the exist() method checks whether the reader is null and re-opens it if necessary, so reader = null is needed.
> make spell checker test case work again
> ---------------------------------------
>
> Key: LUCENE-883
> URL: https://issues.apache.org/jira/browse/LUCENE-883
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Daniel Naber
> Attachments: lucene-spellchecker-2.diff
>
>
> See attached path which makes the spellchecker test case work again. The problem without the patch is that consecutive calls to indexDictionary() will create a spelling index with duplicate words. Does anybody see a problem with this patch? I see that the spellchecker code is now used in Solr, isn't it? I didn't have time to test this patch inside Solr.
> Also see http://issues.apache.org/jira/browse/LUCENE-632, but the null check is included in this patch so the NPE described there cannot happen anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-883) make spell checker test case work
again
Posted by "Daniel Naber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Naber updated LUCENE-883:
--------------------------------
Attachment: lucene-spellchecker-2.diff
patch to make test case work again
> make spell checker test case work again
> ---------------------------------------
>
> Key: LUCENE-883
> URL: https://issues.apache.org/jira/browse/LUCENE-883
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Daniel Naber
> Attachments: lucene-spellchecker-2.diff
>
>
> See attached path which makes the spellchecker test case work again. The problem without the patch is that consecutive calls to indexDictionary() will create a spelling index with duplicate words. Does anybody see a problem with this patch? I see that the spellchecker code is now used in Solr, isn't it? I didn't have time to test this patch inside Solr.
> Also see http://issues.apache.org/jira/browse/LUCENE-632, but the null check is included in this patch so the NPE described there cannot happen anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Closed: (LUCENE-883) make spell checker test case work again
Posted by "Daniel Naber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Naber closed LUCENE-883.
-------------------------------
Resolution: Fixed
Fix Version/s: 2.2
Lucene Fields: [New, Patch Available] (was: [Patch Available, New])
Patch applied.
> make spell checker test case work again
> ---------------------------------------
>
> Key: LUCENE-883
> URL: https://issues.apache.org/jira/browse/LUCENE-883
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Daniel Naber
> Fix For: 2.2
>
> Attachments: lucene-spellchecker-2.diff
>
>
> See attached path which makes the spellchecker test case work again. The problem without the patch is that consecutive calls to indexDictionary() will create a spelling index with duplicate words. Does anybody see a problem with this patch? I see that the spellchecker code is now used in Solr, isn't it? I didn't have time to test this patch inside Solr.
> Also see http://issues.apache.org/jira/browse/LUCENE-632, but the null check is included in this patch so the NPE described there cannot happen anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-883) make spell checker test case work
again
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496776 ]
Otis Gospodnetic commented on LUCENE-883:
-----------------------------------------
Do you need reader=null?
Do you need to close reader explicitly here? searcher.close() can close it, depending on which searcher ctor was used, if I recall correctly. Not sure which one is used in spellchecker, off the top of my head.
Re Solr - yes, I added that to Solr in SOLR-81.
> make spell checker test case work again
> ---------------------------------------
>
> Key: LUCENE-883
> URL: https://issues.apache.org/jira/browse/LUCENE-883
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Daniel Naber
> Attachments: lucene-spellchecker-2.diff
>
>
> See attached path which makes the spellchecker test case work again. The problem without the patch is that consecutive calls to indexDictionary() will create a spelling index with duplicate words. Does anybody see a problem with this patch? I see that the spellchecker code is now used in Solr, isn't it? I didn't have time to test this patch inside Solr.
> Also see http://issues.apache.org/jira/browse/LUCENE-632, but the null check is included in this patch so the NPE described there cannot happen anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org