You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/20 07:32:23 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #6289: UI: hide Virtual Routers tab for domain admins
weizhouapache opened a new pull request, #6289:
URL: https://github.com/apache/cloudstack/pull/6289
### Description
Although domain admins are able to list routers by api, the `Virtual Router` tab was hidden in legacy UI for domain admins.
There are few issues with the page on UI, see #6191
Therefore hide the tab for domain admin in primate UI as well.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6289: UI: hide Virtual Routers tab for domain admins
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6289:
URL: https://github.com/apache/cloudstack/pull/6289#issuecomment-1103610913
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
|Volume|109|0|2|0|44|0|
||
||
|VolumeVO|529|133|4|0|179|39|
|VolumeObject|773|665|77|39|178|117|
|VmwareStorageProcessor|9892|9|940|0|2122|2|
|VolumeJoinDaoImpl|770|0|94|0|171|0|
|VolumeJoinVO|267|0|0|0|93|0|
|ConfigurationManagerImpl|18104|0|3032|0|3570|0|
|IpAddressManagerImpl|4045|0|461|0|806|0|
|ManagementServerImpl|11819|0|1052|0|2361|0|
|VolumeApiServiceImpl|10851|0|1500|0|2035|0|
||
|VirtualMachineMO|8953|135|1063|17|1982|31|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6289: UI: hide Virtual Routers tab for domain admins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6289:
URL: https://github.com/apache/cloudstack/pull/6289#issuecomment-1103566572
@acs-robot a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6289: UI: hide Virtual Routers tab for domain admins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6289:
URL: https://github.com/apache/cloudstack/pull/6289#issuecomment-1103946139
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6289 (SL-JID-1411)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6289: UI: hide Virtual Routers tab for domain admins
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6289:
URL: https://github.com/apache/cloudstack/pull/6289#issuecomment-1103566357
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6289: UI: hide Virtual Routers tab for domain admins
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6289:
URL: https://github.com/apache/cloudstack/pull/6289#issuecomment-1103566371
Found Java/XML changes, kicking packaging job
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6289: UI: hide Virtual Routers tab for domain admins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6289:
URL: https://github.com/apache/cloudstack/pull/6289#issuecomment-1103939937
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6289: UI: hide Virtual Routers tab for domain admins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6289:
URL: https://github.com/apache/cloudstack/pull/6289#issuecomment-1103615564
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6289: UI: hide Virtual Routers tab for domain admins
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6289:
URL: https://github.com/apache/cloudstack/pull/6289#issuecomment-1103939370
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6289: UI: hide Virtual Routers tab for domain admins
Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6289:
URL: https://github.com/apache/cloudstack/pull/6289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org