You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andreas Petersson (JIRA)" <ji...@apache.org> on 2009/02/22 18:11:01 UTC

[jira] Created: (WICKET-2120) widen visibiliy of GuiceProxyTargetLocator and findBindingAnnotation

widen visibiliy of GuiceProxyTargetLocator  and  findBindingAnnotation  
------------------------------------------------------------------------

                 Key: WICKET-2120
                 URL: https://issues.apache.org/jira/browse/WICKET-2120
             Project: Wicket
          Issue Type: Wish
          Components: wicket-guice
    Affects Versions: 1.4-RC2
         Environment: wicket+guice with serializable classes with dependencies on non-serializable classes
            Reporter: Andreas Petersson
             Fix For: 1.4-RC3


GuiceProxyTargetLocator to have a public constructor. Currently it is package-access. Furthermore findBindingAnnotation  should be made public static.

my usecase: 
im using LazyInitProxyFactory.createProxy to substitute non-serializable classes with proxies.
see also 

http://www.nabble.com/request%3A-make-GuiceProxyTargetLocator-public-td22135263.html

alternatively, provide a convinience method to wrap injected objects with the injector-specific proxy.

workaround: create a class in the package to get around package-access lmitation, and duplicate code of findBindingAnnotation  


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2120) widen visibiliy of GuiceProxyTargetLocator and findBindingAnnotation

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-2120:
----------------------------------

    Fix Version/s:     (was: 1.4-RC6)
                   1.4-RC7

> widen visibiliy of GuiceProxyTargetLocator  and  findBindingAnnotation  
> ------------------------------------------------------------------------
>
>                 Key: WICKET-2120
>                 URL: https://issues.apache.org/jira/browse/WICKET-2120
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket-guice
>    Affects Versions: 1.4-RC2
>         Environment: wicket+guice with serializable classes with dependencies on non-serializable classes
>            Reporter: Andreas Petersson
>             Fix For: 1.4-RC7
>
>
> GuiceProxyTargetLocator to have a public constructor. Currently it is package-access. Furthermore findBindingAnnotation  should be made public static.
> my usecase: 
> im using LazyInitProxyFactory.createProxy to substitute non-serializable classes with proxies.
> see also 
> http://www.nabble.com/request%3A-make-GuiceProxyTargetLocator-public-td22135263.html
> alternatively, provide a convinience method to wrap injected objects with the injector-specific proxy.
> workaround: create a class in the package to get around package-access lmitation, and duplicate code of findBindingAnnotation  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2120) widen visibiliy of GuiceProxyTargetLocator and findBindingAnnotation

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-2120:
----------------------------------

    Fix Version/s:     (was: 1.4-RC7)
                   1.4-RC8

> widen visibiliy of GuiceProxyTargetLocator  and  findBindingAnnotation  
> ------------------------------------------------------------------------
>
>                 Key: WICKET-2120
>                 URL: https://issues.apache.org/jira/browse/WICKET-2120
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket-guice
>    Affects Versions: 1.4-RC2
>         Environment: wicket+guice with serializable classes with dependencies on non-serializable classes
>            Reporter: Andreas Petersson
>             Fix For: 1.4-RC8
>
>
> GuiceProxyTargetLocator to have a public constructor. Currently it is package-access. Furthermore findBindingAnnotation  should be made public static.
> my usecase: 
> im using LazyInitProxyFactory.createProxy to substitute non-serializable classes with proxies.
> see also 
> http://www.nabble.com/request%3A-make-GuiceProxyTargetLocator-public-td22135263.html
> alternatively, provide a convinience method to wrap injected objects with the injector-specific proxy.
> workaround: create a class in the package to get around package-access lmitation, and duplicate code of findBindingAnnotation  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2120) widen visibiliy of GuiceProxyTargetLocator and findBindingAnnotation

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-2120:
-------------------------------------

    Fix Version/s:     (was: 1.4-RC4)
                   1.4-RC5

> widen visibiliy of GuiceProxyTargetLocator  and  findBindingAnnotation  
> ------------------------------------------------------------------------
>
>                 Key: WICKET-2120
>                 URL: https://issues.apache.org/jira/browse/WICKET-2120
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket-guice
>    Affects Versions: 1.4-RC2
>         Environment: wicket+guice with serializable classes with dependencies on non-serializable classes
>            Reporter: Andreas Petersson
>             Fix For: 1.4-RC5
>
>
> GuiceProxyTargetLocator to have a public constructor. Currently it is package-access. Furthermore findBindingAnnotation  should be made public static.
> my usecase: 
> im using LazyInitProxyFactory.createProxy to substitute non-serializable classes with proxies.
> see also 
> http://www.nabble.com/request%3A-make-GuiceProxyTargetLocator-public-td22135263.html
> alternatively, provide a convinience method to wrap injected objects with the injector-specific proxy.
> workaround: create a class in the package to get around package-access lmitation, and duplicate code of findBindingAnnotation  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2120) widen visibiliy of GuiceProxyTargetLocator and findBindingAnnotation

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-2120:
----------------------------------

    Fix Version/s:     (was: 1.4.1)
                   1.4.2

> widen visibiliy of GuiceProxyTargetLocator  and  findBindingAnnotation  
> ------------------------------------------------------------------------
>
>                 Key: WICKET-2120
>                 URL: https://issues.apache.org/jira/browse/WICKET-2120
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket-guice
>    Affects Versions: 1.4-RC2
>         Environment: wicket+guice with serializable classes with dependencies on non-serializable classes
>            Reporter: Andreas Petersson
>             Fix For: 1.4.2
>
>
> GuiceProxyTargetLocator to have a public constructor. Currently it is package-access. Furthermore findBindingAnnotation  should be made public static.
> my usecase: 
> im using LazyInitProxyFactory.createProxy to substitute non-serializable classes with proxies.
> see also 
> http://www.nabble.com/request%3A-make-GuiceProxyTargetLocator-public-td22135263.html
> alternatively, provide a convinience method to wrap injected objects with the injector-specific proxy.
> workaround: create a class in the package to get around package-access lmitation, and duplicate code of findBindingAnnotation  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-2120) widen visibiliy of GuiceProxyTargetLocator and findBindingAnnotation

Posted by "Andreas Petersson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736850#action_12736850 ] 

Andreas Petersson commented on WICKET-2120:
-------------------------------------------

some comments on this:
1) my method of injecting non-serializable classes into serializable ones (that are not components) broke somewhere between rc3 and rc4. so i will have to rethink it. will take a look at rc7.

2) guice 2.0, released recently, supports injection listeners wich could accomplish what i am trying to do in a much saver way. 
instead of using custom wrapping code, it may be possible to create a guice module which registeres hooks that guice replaces its non-serializable classes with wicket proxies whenever it detects an injection where this is required. wicket-guice integration could become more transparent using those mechanisms introduced in 2.0.

> widen visibiliy of GuiceProxyTargetLocator  and  findBindingAnnotation  
> ------------------------------------------------------------------------
>
>                 Key: WICKET-2120
>                 URL: https://issues.apache.org/jira/browse/WICKET-2120
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket-guice
>    Affects Versions: 1.4-RC2
>         Environment: wicket+guice with serializable classes with dependencies on non-serializable classes
>            Reporter: Andreas Petersson
>             Fix For: 1.4.1
>
>
> GuiceProxyTargetLocator to have a public constructor. Currently it is package-access. Furthermore findBindingAnnotation  should be made public static.
> my usecase: 
> im using LazyInitProxyFactory.createProxy to substitute non-serializable classes with proxies.
> see also 
> http://www.nabble.com/request%3A-make-GuiceProxyTargetLocator-public-td22135263.html
> alternatively, provide a convinience method to wrap injected objects with the injector-specific proxy.
> workaround: create a class in the package to get around package-access lmitation, and duplicate code of findBindingAnnotation  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2120) widen visibiliy of GuiceProxyTargetLocator and findBindingAnnotation

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-2120:
-------------------------------------

    Fix Version/s:     (was: 1.4-RC5)
                   1.4-RC6

> widen visibiliy of GuiceProxyTargetLocator  and  findBindingAnnotation  
> ------------------------------------------------------------------------
>
>                 Key: WICKET-2120
>                 URL: https://issues.apache.org/jira/browse/WICKET-2120
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket-guice
>    Affects Versions: 1.4-RC2
>         Environment: wicket+guice with serializable classes with dependencies on non-serializable classes
>            Reporter: Andreas Petersson
>             Fix For: 1.4-RC6
>
>
> GuiceProxyTargetLocator to have a public constructor. Currently it is package-access. Furthermore findBindingAnnotation  should be made public static.
> my usecase: 
> im using LazyInitProxyFactory.createProxy to substitute non-serializable classes with proxies.
> see also 
> http://www.nabble.com/request%3A-make-GuiceProxyTargetLocator-public-td22135263.html
> alternatively, provide a convinience method to wrap injected objects with the injector-specific proxy.
> workaround: create a class in the package to get around package-access lmitation, and duplicate code of findBindingAnnotation  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2120) widen visibiliy of GuiceProxyTargetLocator and findBindingAnnotation

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-2120:
----------------------------------

    Fix Version/s:     (was: 1.4.0)
                   1.4.1

> widen visibiliy of GuiceProxyTargetLocator  and  findBindingAnnotation  
> ------------------------------------------------------------------------
>
>                 Key: WICKET-2120
>                 URL: https://issues.apache.org/jira/browse/WICKET-2120
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket-guice
>    Affects Versions: 1.4-RC2
>         Environment: wicket+guice with serializable classes with dependencies on non-serializable classes
>            Reporter: Andreas Petersson
>             Fix For: 1.4.1
>
>
> GuiceProxyTargetLocator to have a public constructor. Currently it is package-access. Furthermore findBindingAnnotation  should be made public static.
> my usecase: 
> im using LazyInitProxyFactory.createProxy to substitute non-serializable classes with proxies.
> see also 
> http://www.nabble.com/request%3A-make-GuiceProxyTargetLocator-public-td22135263.html
> alternatively, provide a convinience method to wrap injected objects with the injector-specific proxy.
> workaround: create a class in the package to get around package-access lmitation, and duplicate code of findBindingAnnotation  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-2120) widen visibiliy of GuiceProxyTargetLocator and findBindingAnnotation

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-2120.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M1
         Assignee: Igor Vaynberg

> widen visibiliy of GuiceProxyTargetLocator  and  findBindingAnnotation  
> ------------------------------------------------------------------------
>
>                 Key: WICKET-2120
>                 URL: https://issues.apache.org/jira/browse/WICKET-2120
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket-guice
>    Affects Versions: 1.4-RC2
>         Environment: wicket+guice with serializable classes with dependencies on non-serializable classes
>            Reporter: Andreas Petersson
>            Assignee: Igor Vaynberg
>             Fix For: 1.4.2, 1.5-M1
>
>
> GuiceProxyTargetLocator to have a public constructor. Currently it is package-access. Furthermore findBindingAnnotation  should be made public static.
> my usecase: 
> im using LazyInitProxyFactory.createProxy to substitute non-serializable classes with proxies.
> see also 
> http://www.nabble.com/request%3A-make-GuiceProxyTargetLocator-public-td22135263.html
> alternatively, provide a convinience method to wrap injected objects with the injector-specific proxy.
> workaround: create a class in the package to get around package-access lmitation, and duplicate code of findBindingAnnotation  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2120) widen visibiliy of GuiceProxyTargetLocator and findBindingAnnotation

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-2120:
-------------------------------------

    Fix Version/s:     (was: 1.4-RC3)
                   1.4-RC4

> widen visibiliy of GuiceProxyTargetLocator  and  findBindingAnnotation  
> ------------------------------------------------------------------------
>
>                 Key: WICKET-2120
>                 URL: https://issues.apache.org/jira/browse/WICKET-2120
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket-guice
>    Affects Versions: 1.4-RC2
>         Environment: wicket+guice with serializable classes with dependencies on non-serializable classes
>            Reporter: Andreas Petersson
>             Fix For: 1.4-RC4
>
>
> GuiceProxyTargetLocator to have a public constructor. Currently it is package-access. Furthermore findBindingAnnotation  should be made public static.
> my usecase: 
> im using LazyInitProxyFactory.createProxy to substitute non-serializable classes with proxies.
> see also 
> http://www.nabble.com/request%3A-make-GuiceProxyTargetLocator-public-td22135263.html
> alternatively, provide a convinience method to wrap injected objects with the injector-specific proxy.
> workaround: create a class in the package to get around package-access lmitation, and duplicate code of findBindingAnnotation  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.