You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by Andy LoPresto <al...@gmail.com> on 2016/07/23 07:04:20 UTC
Re: incubator-pirk git commit: closes apache/incubator-pirk#19 *Won't fix*
Forgive me if I missed something, but it appears this is a 0-diff commit to close a ticket as "Won't fix"? In case you were not aware, you can close the Jira issue without committing to the repository.
Andy LoPresto
alopresto@apache.org
alopresto.apache@gmail.com
PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69
> On Jul 22, 2016, at 23:29, smarthi@apache.org wrote:
>
> Repository: incubator-pirk
> Updated Branches:
> refs/heads/master d9d3adf13 -> ec5104440
>
>
> closes apache/incubator-pirk#19 *Won't fix*
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-pirk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-pirk/commit/ec510444
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-pirk/tree/ec510444
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-pirk/diff/ec510444
>
> Branch: refs/heads/master
> Commit: ec5104440755fc915a2ef3d9d8a2dfa912d61eed
> Parents: d9d3adf
> Author: smarthi <sm...@apache.org>
> Authored: Sat Jul 23 02:28:23 2016 -0400
> Committer: smarthi <sm...@apache.org>
> Committed: Sat Jul 23 02:28:23 2016 -0400
>
> ----------------------------------------------------------------------
>
> ----------------------------------------------------------------------
>
>
Re: incubator-pirk git commit: closes apache/incubator-pirk#19 *Won't fix*
Posted by Suneel Marthi <su...@gmail.com>.
That's been experience on mahout too, it wouldn't close PRs on branch and would only work on master. Most often we ended up doing what I did today - a dummy commit to close an already merged PR
Sent from my iPhone
> On Jul 23, 2016, at 3:46 AM, Andy LoPresto <al...@gmail.com> wrote:
>
> No worries. This kind of stuff is part of the learning curve.
>
> In the future, check that the commit message matches the regex to close, and as long as you are merging to master, it should be good. We ran into issues when supporting a dual branch (0.x and 1.0) setup where merging to 0.x would not close PRs even with the magic words.
>
> Andy LoPresto
> alopresto@apache.org
> alopresto.apache@gmail.com
> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69
>
>> On Jul 23, 2016, at 00:06, Suneel Marthi <su...@gmail.com> wrote:
>>
>> yeah, the PR was merged into master, but not sure why it didn' get closed.
>>
>> So ended up doing a dummy commit to close the PR, next time will follow ur
>> suggestion.
>>
>> Thanks Andy.
>>
>> Suneel
>>
>>
>> On Sat, Jul 23, 2016 at 3:04 AM, Andy LoPresto <al...@gmail.com>
>> wrote:
>>
>>> Forgive me if I missed something, but it appears this is a 0-diff commit
>>> to close a ticket as "Won't fix"? In case you were not aware, you can close
>>> the Jira issue without committing to the repository.
>>>
>>> Andy LoPresto
>>> alopresto@apache.org
>>> alopresto.apache@gmail.com
>>> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69
>>>
>>>> On Jul 22, 2016, at 23:29, smarthi@apache.org wrote:
>>>>
>>>> Repository: incubator-pirk
>>>> Updated Branches:
>>>> refs/heads/master d9d3adf13 -> ec5104440
>>>>
>>>>
>>>> closes apache/incubator-pirk#19 *Won't fix*
>>>>
>>>>
>>>> Project: http://git-wip-us.apache.org/repos/asf/incubator-pirk/repo
>>>> Commit:
>>> http://git-wip-us.apache.org/repos/asf/incubator-pirk/commit/ec510444
>>>> Tree:
>>> http://git-wip-us.apache.org/repos/asf/incubator-pirk/tree/ec510444
>>>> Diff:
>>> http://git-wip-us.apache.org/repos/asf/incubator-pirk/diff/ec510444
>>>>
>>>> Branch: refs/heads/master
>>>> Commit: ec5104440755fc915a2ef3d9d8a2dfa912d61eed
>>>> Parents: d9d3adf
>>>> Author: smarthi <sm...@apache.org>
>>>> Authored: Sat Jul 23 02:28:23 2016 -0400
>>>> Committer: smarthi <sm...@apache.org>
>>>> Committed: Sat Jul 23 02:28:23 2016 -0400
>>>>
>>>> ----------------------------------------------------------------------
>>>>
>>>> ----------------------------------------------------------------------
>>>
Re: incubator-pirk git commit: closes apache/incubator-pirk#19 *Won't fix*
Posted by Andy LoPresto <al...@gmail.com>.
No worries. This kind of stuff is part of the learning curve.
In the future, check that the commit message matches the regex to close, and as long as you are merging to master, it should be good. We ran into issues when supporting a dual branch (0.x and 1.0) setup where merging to 0.x would not close PRs even with the magic words.
Andy LoPresto
alopresto@apache.org
alopresto.apache@gmail.com
PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69
> On Jul 23, 2016, at 00:06, Suneel Marthi <su...@gmail.com> wrote:
>
> yeah, the PR was merged into master, but not sure why it didn' get closed.
>
> So ended up doing a dummy commit to close the PR, next time will follow ur
> suggestion.
>
> Thanks Andy.
>
> Suneel
>
>
> On Sat, Jul 23, 2016 at 3:04 AM, Andy LoPresto <al...@gmail.com>
> wrote:
>
>> Forgive me if I missed something, but it appears this is a 0-diff commit
>> to close a ticket as "Won't fix"? In case you were not aware, you can close
>> the Jira issue without committing to the repository.
>>
>> Andy LoPresto
>> alopresto@apache.org
>> alopresto.apache@gmail.com
>> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69
>>
>>> On Jul 22, 2016, at 23:29, smarthi@apache.org wrote:
>>>
>>> Repository: incubator-pirk
>>> Updated Branches:
>>> refs/heads/master d9d3adf13 -> ec5104440
>>>
>>>
>>> closes apache/incubator-pirk#19 *Won't fix*
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/incubator-pirk/repo
>>> Commit:
>> http://git-wip-us.apache.org/repos/asf/incubator-pirk/commit/ec510444
>>> Tree:
>> http://git-wip-us.apache.org/repos/asf/incubator-pirk/tree/ec510444
>>> Diff:
>> http://git-wip-us.apache.org/repos/asf/incubator-pirk/diff/ec510444
>>>
>>> Branch: refs/heads/master
>>> Commit: ec5104440755fc915a2ef3d9d8a2dfa912d61eed
>>> Parents: d9d3adf
>>> Author: smarthi <sm...@apache.org>
>>> Authored: Sat Jul 23 02:28:23 2016 -0400
>>> Committer: smarthi <sm...@apache.org>
>>> Committed: Sat Jul 23 02:28:23 2016 -0400
>>>
>>> ----------------------------------------------------------------------
>>>
>>> ----------------------------------------------------------------------
>>
Re: incubator-pirk git commit: closes apache/incubator-pirk#19 *Won't fix*
Posted by Suneel Marthi <su...@gmail.com>.
yeah, the PR was merged into master, but not sure why it didn' get closed.
So ended up doing a dummy commit to close the PR, next time will follow ur
suggestion.
Thanks Andy.
Suneel
On Sat, Jul 23, 2016 at 3:04 AM, Andy LoPresto <al...@gmail.com>
wrote:
> Forgive me if I missed something, but it appears this is a 0-diff commit
> to close a ticket as "Won't fix"? In case you were not aware, you can close
> the Jira issue without committing to the repository.
>
> Andy LoPresto
> alopresto@apache.org
> alopresto.apache@gmail.com
> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69
>
> > On Jul 22, 2016, at 23:29, smarthi@apache.org wrote:
> >
> > Repository: incubator-pirk
> > Updated Branches:
> > refs/heads/master d9d3adf13 -> ec5104440
> >
> >
> > closes apache/incubator-pirk#19 *Won't fix*
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/incubator-pirk/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/incubator-pirk/commit/ec510444
> > Tree:
> http://git-wip-us.apache.org/repos/asf/incubator-pirk/tree/ec510444
> > Diff:
> http://git-wip-us.apache.org/repos/asf/incubator-pirk/diff/ec510444
> >
> > Branch: refs/heads/master
> > Commit: ec5104440755fc915a2ef3d9d8a2dfa912d61eed
> > Parents: d9d3adf
> > Author: smarthi <sm...@apache.org>
> > Authored: Sat Jul 23 02:28:23 2016 -0400
> > Committer: smarthi <sm...@apache.org>
> > Committed: Sat Jul 23 02:28:23 2016 -0400
> >
> > ----------------------------------------------------------------------
> >
> > ----------------------------------------------------------------------
> >
> >
>