jhutchison opened a new pull request #6098: URL: https://github.com/apache/geode/pull/6098 …compatibility commands - Update docs for INCRBYFLOAT - Update docs for HGET - move HEXISTS and STRLEN to supported commands - Move HINCRBYFLOAT to supported - move DECR to list of supported commands - Move MGET and HDEL to supported - add hkeys to list of supported commands - add incrby to list of supported commands - Move SETNX and GETRANGE to supported - update RedisCommandType & fix missing changes in doc files Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org
jhutchison commented on pull request #6098: URL: https://github.com/apache/geode/pull/6098#issuecomment-792912960 > Thanks for making those updates! Weird thing I just noticed... it looks like the lists of supported and unsupported commands have not been updated in the `SupportedCommandsJUnitTest` to match the changes in `RedisCommandType` ...I'm not sure how those tests are passing in the pipeline, but there are failures when I run them locally. updated with develop ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org
jhutchison commented on a change in pull request #6098:
URL: https://github.com/apache/geode/pull/6098#discussion_r589520522
##########
File path: geode-redis/README.md
##########
@@ -159,54 +159,54 @@ start server \
|-----------------------|-------------------------------------------------------|-----------------------------------|
| APPEND | BITCOUNT | ACL CAT |
| AUTH | BITOP | ACL DELUSER |
-| DEL | BITPOS | ACL GENPASS |
-| EXISTS | DBSIZE | ACL GETUSER |
-| EXPIRE | DECR | ACL HELP |
-| EXPIREAT | DECRBY | ACL LIST |
-| GET | ECHO | ACL LOAD |
-| HGETALL | FLUSHALL | ACL LOG |
-| HMGET | FLUSHDB | ACL SAVE |
-| HMSET | GETBIT | ACL SETUSER |
-| HSET | GETRANGE | ACL USERS |
-| HSETNX | GETSET | ACL WHOAMI |
-| HSTRLEN | HDEL | BGREWRITEAOF |
-| HLEN | HEXISTS | BGSAVE |
-| HVALS | HGET | BITFIELD |
-| KEYS | HINCRBY | BLPOP |
-| PERSIST | HINCRBYFLOAT | BRPOP |
-| PEXPIRE | HKEYS | BRPOPLPUSH |
-| PEXPIREAT | HSCAN | BZPOPMAX |
-| PING | INCR | BZPOPMIN |
-| PSUBSCRIBE | INCRBY | CLIENT CACHING |
-| PTTL | INCRBYFLOAT | CLIENT GETNAME |
-| PUBLISH | INFO | CLIENT GETREDIR |
-| PUNSUBSCRIBE | MGET | CLIENT ID |
-| QUIT | MSET | CLIENT KILL |
-| RENAME | MSETNX | CLIENT LIST |
-| SADD | PSETEX | CLIENT PAUSE |
-| SET | SCAN | CLIENT REPLY |
-| SMEMBERS | SCARD | CLIENT SETNAME |
-| SREM | SDIFF | CLIENT TRACKING |
-| SUBSCRIBE | SDIFFSTORE | CLIENT UNBLOCK |
-| TTL | SELECT | CLUSTER ADDSLOTS |
-| TYPE | SETBIT | CLUSTER BUMPEPOCH |
-| UNSUBSCRIBE | SETEX | CLUSTER COUNT-FAILURE-REPORTS |
-| | SETNX | CLUSTER COUNTKEYSINSLOT |
-| | SETRANGE | CLUSTER DELSLOTS |
-| | SHUTDOWN | CLUSTER FAILOVER |
-| | SINTER | CLUSTER FLUSHSLOTS |
-| | SINTERSTORE | CLUSTER FORGET |
-| | SISMEMBER | CLUSTER GETKEYSINSLOT |
-| | SLOWLOG | CLUSTER INFO |
-| | SMOVE | CLUSTER KEYSLOT |
-| | SPOP | CLUSTER MEET |
-| | SRANDMEMBER | CLUSTER MYID |
-| | SSCAN | CLUSTER NODES |
-| | STRLEN | CLUSTER REPLICAS |
-| | SUNION | CLUSTER REPLICATE |
-| | SUNIONSTORE | CLUSTER RESET |
-| | TIME | CLUSTER SAVECONFIG |
-| | UNLINK [1] | CLUSTER SET-CONFIG-EPOCH |
+| DECR | BITPOS | ACL GENPASS |
+| DEL | DBSIZE | ACL GETUSER |
+| EXISTS | DECRBY | ACL HELP |
+| EXPIRE | ECHO | ACL LIST |
+| EXPIREAT | FLUSHALL | ACL LOAD |
+| GET | FLUSHDB | ACL LOG |
+| GETRANGE | GETBIT | ACL SAVE |
+| HDEL | GETSET | ACL SETUSER |
+| HEXISTS | HINCRBY | ACL USERS |
+| HKEYS | HSCAN | ACL WHOAMI |
+| HGET | INCR | BGREWRITEAOF |
+| HGETALL | INFO | BGSAVE |
+| HINCRBY | MSET | BITFIELD
+| HINCRBYFLOAT | MSETNX | BLPOP |
+| HMGET | PSETEX | BRPOP |
+| HMSET | SCAN | BRPOPLPUSH | |
+| HSCAN | SCARD | BZPOPMAX |
+| HSET | SDIFF | BZPOPMIN |
+| HSETNX | SDIFFSTORE | CLIENT CACHING |
+| HSTRLEN | SELECT | CLIENT GETNAME |
+| HLEN | SETBIT | CLIENT GETREDIR |
+| HVALS | SETEX | CLIENT ID
Review comment:
sure. done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 commented on pull request #6098: URL: https://github.com/apache/geode/pull/6098#issuecomment-792935852 > updated with develop Oh, that makes so much sense now... the pipeline rebases with develop before testing. :octocat: 🤦 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org
jhutchison commented on a change in pull request #6098:
URL: https://github.com/apache/geode/pull/6098#discussion_r589757081
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -41,6 +41,8 @@ start server \
--redis-password=<redisPassword>
```
+Note: if any of redis-bind-address, redis-password, or redis-port are included, a compatible-with-Redis geode server will be started
Review comment:
changed. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
karensmolermiller commented on a change in pull request #6098:
URL: https://github.com/apache/geode/pull/6098#discussion_r589749861
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -41,6 +41,8 @@ start server \
--redis-password=<redisPassword>
```
+Note: if any of redis-bind-address, redis-password, or redis-port are included, a compatible-with-Redis geode server will be started
Review comment:
Please revise this sentence with some formatting and capitalization changes. I suggest:
If any of the options `redis-bind-address`, `redis-password`, or `redis-port` are included, a compatible-with-Redis Geode server will be started.
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -68,26 +70,24 @@ The Redis API for <%=vars.product_name%> currently supports the following comman
**Note**: These commands are supported for Redis 5.
- **Connection**: AUTH, PING, QUIT
-- **Hashes**: HGETALL, HMGET, HMSET, HSET, HSETNX, HSTRLEN, HLEN, HVALS
+- **Hashes**:HDEL, HEXISTS, HGET, HGETALL, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HMSET, HSCAN, HSET, HSETNX, HSTRLEN, HVALS
Review comment:
Add a space after the colon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6098:
URL: https://github.com/apache/geode/pull/6098#discussion_r589523346
##########
File path: geode-redis/README.md
##########
@@ -159,54 +159,54 @@ start server \
|-----------------------|-------------------------------------------------------|-----------------------------------|
| APPEND | BITCOUNT | ACL CAT |
| AUTH | BITOP | ACL DELUSER |
-| DEL | BITPOS | ACL GENPASS |
-| EXISTS | DBSIZE | ACL GETUSER |
-| EXPIRE | DECR | ACL HELP |
-| EXPIREAT | DECRBY | ACL LIST |
-| GET | ECHO | ACL LOAD |
-| HGETALL | FLUSHALL | ACL LOG |
-| HMGET | FLUSHDB | ACL SAVE |
-| HMSET | GETBIT | ACL SETUSER |
-| HSET | GETRANGE | ACL USERS |
-| HSETNX | GETSET | ACL WHOAMI |
-| HSTRLEN | HDEL | BGREWRITEAOF |
-| HLEN | HEXISTS | BGSAVE |
-| HVALS | HGET | BITFIELD |
-| KEYS | HINCRBY | BLPOP |
-| PERSIST | HINCRBYFLOAT | BRPOP |
-| PEXPIRE | HKEYS | BRPOPLPUSH |
-| PEXPIREAT | HSCAN | BZPOPMAX |
-| PING | INCR | BZPOPMIN |
-| PSUBSCRIBE | INCRBY | CLIENT CACHING |
-| PTTL | INCRBYFLOAT | CLIENT GETNAME |
-| PUBLISH | INFO | CLIENT GETREDIR |
-| PUNSUBSCRIBE | MGET | CLIENT ID |
-| QUIT | MSET | CLIENT KILL |
-| RENAME | MSETNX | CLIENT LIST |
-| SADD | PSETEX | CLIENT PAUSE |
-| SET | SCAN | CLIENT REPLY |
-| SMEMBERS | SCARD | CLIENT SETNAME |
-| SREM | SDIFF | CLIENT TRACKING |
-| SUBSCRIBE | SDIFFSTORE | CLIENT UNBLOCK |
-| TTL | SELECT | CLUSTER ADDSLOTS |
-| TYPE | SETBIT | CLUSTER BUMPEPOCH |
-| UNSUBSCRIBE | SETEX | CLUSTER COUNT-FAILURE-REPORTS |
-| | SETNX | CLUSTER COUNTKEYSINSLOT |
-| | SETRANGE | CLUSTER DELSLOTS |
-| | SHUTDOWN | CLUSTER FAILOVER |
-| | SINTER | CLUSTER FLUSHSLOTS |
-| | SINTERSTORE | CLUSTER FORGET |
-| | SISMEMBER | CLUSTER GETKEYSINSLOT |
-| | SLOWLOG | CLUSTER INFO |
-| | SMOVE | CLUSTER KEYSLOT |
-| | SPOP | CLUSTER MEET |
-| | SRANDMEMBER | CLUSTER MYID |
-| | SSCAN | CLUSTER NODES |
-| | STRLEN | CLUSTER REPLICAS |
-| | SUNION | CLUSTER REPLICATE |
-| | SUNIONSTORE | CLUSTER RESET |
-| | TIME | CLUSTER SAVECONFIG |
-| | UNLINK [1] | CLUSTER SET-CONFIG-EPOCH |
+| DECR | BITPOS | ACL GENPASS |
+| DEL | DBSIZE | ACL GETUSER |
+| EXISTS | DECRBY | ACL HELP |
+| EXPIRE | ECHO | ACL LIST |
+| EXPIREAT | FLUSHALL | ACL LOAD |
+| GET | FLUSHDB | ACL LOG |
+| GETRANGE | GETBIT | ACL SAVE |
+| HDEL | GETSET | ACL SETUSER |
+| HEXISTS | HINCRBY | ACL USERS |
+| HKEYS | HSCAN | ACL WHOAMI |
+| HGET | INCR | BGREWRITEAOF |
+| HGETALL | INFO | BGSAVE |
+| HINCRBY | MSET | BITFIELD
+| HINCRBYFLOAT | MSETNX | BLPOP |
+| HMGET | PSETEX | BRPOP |
+| HMSET | SCAN | BRPOPLPUSH | |
+| HSCAN | SCARD | BZPOPMAX |
+| HSET | SDIFF | BZPOPMIN |
+| HSETNX | SDIFFSTORE | CLIENT CACHING |
+| HSTRLEN | SELECT | CLIENT GETNAME |
+| HLEN | SETBIT | CLIENT GETREDIR |
+| HVALS | SETEX | CLIENT ID
+| INCRBY | SETRANGE | CLIENT KILL |
+| INCRBYFLOAT | SHUTDOWN | CLIENT LIST |
+| KEYS | SINTER | CLIENT PAUSE |
+| MGET | SINTERSTORE | CLIENT REPLY |
+| PERSIST | SISMEMBER | CLIENT SETNAME |
+| PEXPIRE | SLOWLOG | CLIENT TRACKING |
+| PEXPIREAT | SMOVE | CLIENT UNBLOCK |
+| PING | SPOP | CLUSTER ADDSLOTS |
+| PSUBSCRIBE | SRANDMEMBER | CLUSTER BUMPEPOCH
+| PTTL | SSCAN | CLUSTER COUNT-FAILURE-REPORTS |
+| PUBLISH | SUNION | CLUSTER COUNTKEYSINSLOT |
+| PUNSUBSCRIBE | SUNIONSTORE | CLUSTER DELSLOTS |
+| QUIT | TIME | CLUSTER FAILOVER |
+| RENAME | UNLINK [1] | CLUSTER FLUSHSLOTS |
+| SADD | CLUSTER FORGET |
+| SET | CLUSTER GETKEYSINSLOT |
+| SETNX | CLUSTER INFO |
+| SMEMBERS | CLUSTER KEYSLOT |
+| SREM | CLUSTER MEET |
Review comment:
added back. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6098:
URL: https://github.com/apache/geode/pull/6098#discussion_r589517494
##########
File path: geode-redis/README.md
##########
@@ -159,54 +159,54 @@ start server \
|-----------------------|-------------------------------------------------------|-----------------------------------|
| APPEND | BITCOUNT | ACL CAT |
| AUTH | BITOP | ACL DELUSER |
-| DEL | BITPOS | ACL GENPASS |
-| EXISTS | DBSIZE | ACL GETUSER |
-| EXPIRE | DECR | ACL HELP |
-| EXPIREAT | DECRBY | ACL LIST |
-| GET | ECHO | ACL LOAD |
-| HGETALL | FLUSHALL | ACL LOG |
-| HMGET | FLUSHDB | ACL SAVE |
-| HMSET | GETBIT | ACL SETUSER |
-| HSET | GETRANGE | ACL USERS |
-| HSETNX | GETSET | ACL WHOAMI |
-| HSTRLEN | HDEL | BGREWRITEAOF |
-| HLEN | HEXISTS | BGSAVE |
-| HVALS | HGET | BITFIELD |
-| KEYS | HINCRBY | BLPOP |
-| PERSIST | HINCRBYFLOAT | BRPOP |
-| PEXPIRE | HKEYS | BRPOPLPUSH |
-| PEXPIREAT | HSCAN | BZPOPMAX |
-| PING | INCR | BZPOPMIN |
-| PSUBSCRIBE | INCRBY | CLIENT CACHING |
-| PTTL | INCRBYFLOAT | CLIENT GETNAME |
-| PUBLISH | INFO | CLIENT GETREDIR |
-| PUNSUBSCRIBE | MGET | CLIENT ID |
-| QUIT | MSET | CLIENT KILL |
-| RENAME | MSETNX | CLIENT LIST |
-| SADD | PSETEX | CLIENT PAUSE |
-| SET | SCAN | CLIENT REPLY |
-| SMEMBERS | SCARD | CLIENT SETNAME |
-| SREM | SDIFF | CLIENT TRACKING |
-| SUBSCRIBE | SDIFFSTORE | CLIENT UNBLOCK |
-| TTL | SELECT | CLUSTER ADDSLOTS |
-| TYPE | SETBIT | CLUSTER BUMPEPOCH |
-| UNSUBSCRIBE | SETEX | CLUSTER COUNT-FAILURE-REPORTS |
-| | SETNX | CLUSTER COUNTKEYSINSLOT |
-| | SETRANGE | CLUSTER DELSLOTS |
-| | SHUTDOWN | CLUSTER FAILOVER |
-| | SINTER | CLUSTER FLUSHSLOTS |
-| | SINTERSTORE | CLUSTER FORGET |
-| | SISMEMBER | CLUSTER GETKEYSINSLOT |
-| | SLOWLOG | CLUSTER INFO |
-| | SMOVE | CLUSTER KEYSLOT |
-| | SPOP | CLUSTER MEET |
-| | SRANDMEMBER | CLUSTER MYID |
-| | SSCAN | CLUSTER NODES |
-| | STRLEN | CLUSTER REPLICAS |
-| | SUNION | CLUSTER REPLICATE |
-| | SUNIONSTORE | CLUSTER RESET |
-| | TIME | CLUSTER SAVECONFIG |
-| | UNLINK [1] | CLUSTER SET-CONFIG-EPOCH |
+| DECR | BITPOS | ACL GENPASS |
+| DEL | DBSIZE | ACL GETUSER |
+| EXISTS | DECRBY | ACL HELP |
+| EXPIRE | ECHO | ACL LIST |
+| EXPIREAT | FLUSHALL | ACL LOAD |
+| GET | FLUSHDB | ACL LOG |
+| GETRANGE | GETBIT | ACL SAVE |
+| HDEL | GETSET | ACL SETUSER |
+| HEXISTS | HINCRBY | ACL USERS |
+| HKEYS | HSCAN | ACL WHOAMI |
+| HGET | INCR | BGREWRITEAOF |
Review comment:
thanks- changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6098:
URL: https://github.com/apache/geode/pull/6098#discussion_r589518507
##########
File path: geode-redis/README.md
##########
@@ -159,54 +159,54 @@ start server \
|-----------------------|-------------------------------------------------------|-----------------------------------|
| APPEND | BITCOUNT | ACL CAT |
| AUTH | BITOP | ACL DELUSER |
-| DEL | BITPOS | ACL GENPASS |
-| EXISTS | DBSIZE | ACL GETUSER |
-| EXPIRE | DECR | ACL HELP |
-| EXPIREAT | DECRBY | ACL LIST |
-| GET | ECHO | ACL LOAD |
-| HGETALL | FLUSHALL | ACL LOG |
-| HMGET | FLUSHDB | ACL SAVE |
-| HMSET | GETBIT | ACL SETUSER |
-| HSET | GETRANGE | ACL USERS |
-| HSETNX | GETSET | ACL WHOAMI |
-| HSTRLEN | HDEL | BGREWRITEAOF |
-| HLEN | HEXISTS | BGSAVE |
-| HVALS | HGET | BITFIELD |
-| KEYS | HINCRBY | BLPOP |
-| PERSIST | HINCRBYFLOAT | BRPOP |
-| PEXPIRE | HKEYS | BRPOPLPUSH |
-| PEXPIREAT | HSCAN | BZPOPMAX |
-| PING | INCR | BZPOPMIN |
-| PSUBSCRIBE | INCRBY | CLIENT CACHING |
-| PTTL | INCRBYFLOAT | CLIENT GETNAME |
-| PUBLISH | INFO | CLIENT GETREDIR |
-| PUNSUBSCRIBE | MGET | CLIENT ID |
-| QUIT | MSET | CLIENT KILL |
-| RENAME | MSETNX | CLIENT LIST |
-| SADD | PSETEX | CLIENT PAUSE |
-| SET | SCAN | CLIENT REPLY |
-| SMEMBERS | SCARD | CLIENT SETNAME |
-| SREM | SDIFF | CLIENT TRACKING |
-| SUBSCRIBE | SDIFFSTORE | CLIENT UNBLOCK |
-| TTL | SELECT | CLUSTER ADDSLOTS |
-| TYPE | SETBIT | CLUSTER BUMPEPOCH |
-| UNSUBSCRIBE | SETEX | CLUSTER COUNT-FAILURE-REPORTS |
-| | SETNX | CLUSTER COUNTKEYSINSLOT |
-| | SETRANGE | CLUSTER DELSLOTS |
-| | SHUTDOWN | CLUSTER FAILOVER |
-| | SINTER | CLUSTER FLUSHSLOTS |
-| | SINTERSTORE | CLUSTER FORGET |
-| | SISMEMBER | CLUSTER GETKEYSINSLOT |
-| | SLOWLOG | CLUSTER INFO |
-| | SMOVE | CLUSTER KEYSLOT |
-| | SPOP | CLUSTER MEET |
-| | SRANDMEMBER | CLUSTER MYID |
-| | SSCAN | CLUSTER NODES |
-| | STRLEN | CLUSTER REPLICAS |
-| | SUNION | CLUSTER REPLICATE |
-| | SUNIONSTORE | CLUSTER RESET |
-| | TIME | CLUSTER SAVECONFIG |
-| | UNLINK [1] | CLUSTER SET-CONFIG-EPOCH |
+| DECR | BITPOS | ACL GENPASS |
+| DEL | DBSIZE | ACL GETUSER |
+| EXISTS | DECRBY | ACL HELP |
+| EXPIRE | ECHO | ACL LIST |
+| EXPIREAT | FLUSHALL | ACL LOAD |
+| GET | FLUSHDB | ACL LOG |
+| GETRANGE | GETBIT | ACL SAVE |
+| HDEL | GETSET | ACL SETUSER |
+| HEXISTS | HINCRBY | ACL USERS |
+| HKEYS | HSCAN | ACL WHOAMI |
Review comment:
thanks again, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
jhutchison commented on a change in pull request #6098:
URL: https://github.com/apache/geode/pull/6098#discussion_r589757163
##########
File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb
##########
@@ -68,26 +70,24 @@ The Redis API for <%=vars.product_name%> currently supports the following comman
**Note**: These commands are supported for Redis 5.
- **Connection**: AUTH, PING, QUIT
-- **Hashes**: HGETALL, HMGET, HMSET, HSET, HSETNX, HSTRLEN, HLEN, HVALS
+- **Hashes**:HDEL, HEXISTS, HGET, HGETALL, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HMSET, HSCAN, HSET, HSETNX, HSTRLEN, HVALS
Review comment:
added. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
sabbey37 merged pull request #6098: URL: https://github.com/apache/geode/pull/6098 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org
sabbey37 commented on a change in pull request #6098:
URL: https://github.com/apache/geode/pull/6098#discussion_r588760679
##########
File path: geode-redis/README.md
##########
@@ -159,54 +159,54 @@ start server \
|-----------------------|-------------------------------------------------------|-----------------------------------|
| APPEND | BITCOUNT | ACL CAT |
| AUTH | BITOP | ACL DELUSER |
-| DEL | BITPOS | ACL GENPASS |
-| EXISTS | DBSIZE | ACL GETUSER |
-| EXPIRE | DECR | ACL HELP |
-| EXPIREAT | DECRBY | ACL LIST |
-| GET | ECHO | ACL LOAD |
-| HGETALL | FLUSHALL | ACL LOG |
-| HMGET | FLUSHDB | ACL SAVE |
-| HMSET | GETBIT | ACL SETUSER |
-| HSET | GETRANGE | ACL USERS |
-| HSETNX | GETSET | ACL WHOAMI |
-| HSTRLEN | HDEL | BGREWRITEAOF |
-| HLEN | HEXISTS | BGSAVE |
-| HVALS | HGET | BITFIELD |
-| KEYS | HINCRBY | BLPOP |
-| PERSIST | HINCRBYFLOAT | BRPOP |
-| PEXPIRE | HKEYS | BRPOPLPUSH |
-| PEXPIREAT | HSCAN | BZPOPMAX |
-| PING | INCR | BZPOPMIN |
-| PSUBSCRIBE | INCRBY | CLIENT CACHING |
-| PTTL | INCRBYFLOAT | CLIENT GETNAME |
-| PUBLISH | INFO | CLIENT GETREDIR |
-| PUNSUBSCRIBE | MGET | CLIENT ID |
-| QUIT | MSET | CLIENT KILL |
-| RENAME | MSETNX | CLIENT LIST |
-| SADD | PSETEX | CLIENT PAUSE |
-| SET | SCAN | CLIENT REPLY |
-| SMEMBERS | SCARD | CLIENT SETNAME |
-| SREM | SDIFF | CLIENT TRACKING |
-| SUBSCRIBE | SDIFFSTORE | CLIENT UNBLOCK |
-| TTL | SELECT | CLUSTER ADDSLOTS |
-| TYPE | SETBIT | CLUSTER BUMPEPOCH |
-| UNSUBSCRIBE | SETEX | CLUSTER COUNT-FAILURE-REPORTS |
-| | SETNX | CLUSTER COUNTKEYSINSLOT |
-| | SETRANGE | CLUSTER DELSLOTS |
-| | SHUTDOWN | CLUSTER FAILOVER |
-| | SINTER | CLUSTER FLUSHSLOTS |
-| | SINTERSTORE | CLUSTER FORGET |
-| | SISMEMBER | CLUSTER GETKEYSINSLOT |
-| | SLOWLOG | CLUSTER INFO |
-| | SMOVE | CLUSTER KEYSLOT |
-| | SPOP | CLUSTER MEET |
-| | SRANDMEMBER | CLUSTER MYID |
-| | SSCAN | CLUSTER NODES |
-| | STRLEN | CLUSTER REPLICAS |
-| | SUNION | CLUSTER REPLICATE |
-| | SUNIONSTORE | CLUSTER RESET |
-| | TIME | CLUSTER SAVECONFIG |
-| | UNLINK [1] | CLUSTER SET-CONFIG-EPOCH |
+| DECR | BITPOS | ACL GENPASS |
+| DEL | DBSIZE | ACL GETUSER |
+| EXISTS | DECRBY | ACL HELP |
+| EXPIRE | ECHO | ACL LIST |
+| EXPIREAT | FLUSHALL | ACL LOAD |
+| GET | FLUSHDB | ACL LOG |
+| GETRANGE | GETBIT | ACL SAVE |
+| HDEL | GETSET | ACL SETUSER |
+| HEXISTS | HINCRBY | ACL USERS |
+| HKEYS | HSCAN | ACL WHOAMI |
Review comment:
`HINCRBY` and `HSCAN` should be removed from the Unsupported column.
##########
File path: geode-redis/README.md
##########
@@ -159,54 +159,54 @@ start server \
|-----------------------|-------------------------------------------------------|-----------------------------------|
| APPEND | BITCOUNT | ACL CAT |
| AUTH | BITOP | ACL DELUSER |
-| DEL | BITPOS | ACL GENPASS |
-| EXISTS | DBSIZE | ACL GETUSER |
-| EXPIRE | DECR | ACL HELP |
-| EXPIREAT | DECRBY | ACL LIST |
-| GET | ECHO | ACL LOAD |
-| HGETALL | FLUSHALL | ACL LOG |
-| HMGET | FLUSHDB | ACL SAVE |
-| HMSET | GETBIT | ACL SETUSER |
-| HSET | GETRANGE | ACL USERS |
-| HSETNX | GETSET | ACL WHOAMI |
-| HSTRLEN | HDEL | BGREWRITEAOF |
-| HLEN | HEXISTS | BGSAVE |
-| HVALS | HGET | BITFIELD |
-| KEYS | HINCRBY | BLPOP |
-| PERSIST | HINCRBYFLOAT | BRPOP |
-| PEXPIRE | HKEYS | BRPOPLPUSH |
-| PEXPIREAT | HSCAN | BZPOPMAX |
-| PING | INCR | BZPOPMIN |
-| PSUBSCRIBE | INCRBY | CLIENT CACHING |
-| PTTL | INCRBYFLOAT | CLIENT GETNAME |
-| PUBLISH | INFO | CLIENT GETREDIR |
-| PUNSUBSCRIBE | MGET | CLIENT ID |
-| QUIT | MSET | CLIENT KILL |
-| RENAME | MSETNX | CLIENT LIST |
-| SADD | PSETEX | CLIENT PAUSE |
-| SET | SCAN | CLIENT REPLY |
-| SMEMBERS | SCARD | CLIENT SETNAME |
-| SREM | SDIFF | CLIENT TRACKING |
-| SUBSCRIBE | SDIFFSTORE | CLIENT UNBLOCK |
-| TTL | SELECT | CLUSTER ADDSLOTS |
-| TYPE | SETBIT | CLUSTER BUMPEPOCH |
-| UNSUBSCRIBE | SETEX | CLUSTER COUNT-FAILURE-REPORTS |
-| | SETNX | CLUSTER COUNTKEYSINSLOT |
-| | SETRANGE | CLUSTER DELSLOTS |
-| | SHUTDOWN | CLUSTER FAILOVER |
-| | SINTER | CLUSTER FLUSHSLOTS |
-| | SINTERSTORE | CLUSTER FORGET |
-| | SISMEMBER | CLUSTER GETKEYSINSLOT |
-| | SLOWLOG | CLUSTER INFO |
-| | SMOVE | CLUSTER KEYSLOT |
-| | SPOP | CLUSTER MEET |
-| | SRANDMEMBER | CLUSTER MYID |
-| | SSCAN | CLUSTER NODES |
-| | STRLEN | CLUSTER REPLICAS |
-| | SUNION | CLUSTER REPLICATE |
-| | SUNIONSTORE | CLUSTER RESET |
-| | TIME | CLUSTER SAVECONFIG |
-| | UNLINK [1] | CLUSTER SET-CONFIG-EPOCH |
+| DECR | BITPOS | ACL GENPASS |
+| DEL | DBSIZE | ACL GETUSER |
+| EXISTS | DECRBY | ACL HELP |
+| EXPIRE | ECHO | ACL LIST |
+| EXPIREAT | FLUSHALL | ACL LOAD |
+| GET | FLUSHDB | ACL LOG |
+| GETRANGE | GETBIT | ACL SAVE |
+| HDEL | GETSET | ACL SETUSER |
+| HEXISTS | HINCRBY | ACL USERS |
+| HKEYS | HSCAN | ACL WHOAMI |
+| HGET | INCR | BGREWRITEAOF |
+| HGETALL | INFO | BGSAVE |
+| HINCRBY | MSET | BITFIELD
+| HINCRBYFLOAT | MSETNX | BLPOP |
+| HMGET | PSETEX | BRPOP |
+| HMSET | SCAN | BRPOPLPUSH | |
+| HSCAN | SCARD | BZPOPMAX |
+| HSET | SDIFF | BZPOPMIN |
+| HSETNX | SDIFFSTORE | CLIENT CACHING |
+| HSTRLEN | SELECT | CLIENT GETNAME |
+| HLEN | SETBIT | CLIENT GETREDIR |
+| HVALS | SETEX | CLIENT ID
Review comment:
Could we put these hash commands in alphabetical order? (looks like just `HKEYS` and `HLEN` need to be moved.)
##########
File path: geode-redis/README.md
##########
@@ -159,54 +159,54 @@ start server \
|-----------------------|-------------------------------------------------------|-----------------------------------|
| APPEND | BITCOUNT | ACL CAT |
| AUTH | BITOP | ACL DELUSER |
-| DEL | BITPOS | ACL GENPASS |
-| EXISTS | DBSIZE | ACL GETUSER |
-| EXPIRE | DECR | ACL HELP |
-| EXPIREAT | DECRBY | ACL LIST |
-| GET | ECHO | ACL LOAD |
-| HGETALL | FLUSHALL | ACL LOG |
-| HMGET | FLUSHDB | ACL SAVE |
-| HMSET | GETBIT | ACL SETUSER |
-| HSET | GETRANGE | ACL USERS |
-| HSETNX | GETSET | ACL WHOAMI |
-| HSTRLEN | HDEL | BGREWRITEAOF |
-| HLEN | HEXISTS | BGSAVE |
-| HVALS | HGET | BITFIELD |
-| KEYS | HINCRBY | BLPOP |
-| PERSIST | HINCRBYFLOAT | BRPOP |
-| PEXPIRE | HKEYS | BRPOPLPUSH |
-| PEXPIREAT | HSCAN | BZPOPMAX |
-| PING | INCR | BZPOPMIN |
-| PSUBSCRIBE | INCRBY | CLIENT CACHING |
-| PTTL | INCRBYFLOAT | CLIENT GETNAME |
-| PUBLISH | INFO | CLIENT GETREDIR |
-| PUNSUBSCRIBE | MGET | CLIENT ID |
-| QUIT | MSET | CLIENT KILL |
-| RENAME | MSETNX | CLIENT LIST |
-| SADD | PSETEX | CLIENT PAUSE |
-| SET | SCAN | CLIENT REPLY |
-| SMEMBERS | SCARD | CLIENT SETNAME |
-| SREM | SDIFF | CLIENT TRACKING |
-| SUBSCRIBE | SDIFFSTORE | CLIENT UNBLOCK |
-| TTL | SELECT | CLUSTER ADDSLOTS |
-| TYPE | SETBIT | CLUSTER BUMPEPOCH |
-| UNSUBSCRIBE | SETEX | CLUSTER COUNT-FAILURE-REPORTS |
-| | SETNX | CLUSTER COUNTKEYSINSLOT |
-| | SETRANGE | CLUSTER DELSLOTS |
-| | SHUTDOWN | CLUSTER FAILOVER |
-| | SINTER | CLUSTER FLUSHSLOTS |
-| | SINTERSTORE | CLUSTER FORGET |
-| | SISMEMBER | CLUSTER GETKEYSINSLOT |
-| | SLOWLOG | CLUSTER INFO |
-| | SMOVE | CLUSTER KEYSLOT |
-| | SPOP | CLUSTER MEET |
-| | SRANDMEMBER | CLUSTER MYID |
-| | SSCAN | CLUSTER NODES |
-| | STRLEN | CLUSTER REPLICAS |
-| | SUNION | CLUSTER REPLICATE |
-| | SUNIONSTORE | CLUSTER RESET |
-| | TIME | CLUSTER SAVECONFIG |
-| | UNLINK [1] | CLUSTER SET-CONFIG-EPOCH |
+| DECR | BITPOS | ACL GENPASS |
+| DEL | DBSIZE | ACL GETUSER |
+| EXISTS | DECRBY | ACL HELP |
+| EXPIRE | ECHO | ACL LIST |
+| EXPIREAT | FLUSHALL | ACL LOAD |
+| GET | FLUSHDB | ACL LOG |
+| GETRANGE | GETBIT | ACL SAVE |
+| HDEL | GETSET | ACL SETUSER |
+| HEXISTS | HINCRBY | ACL USERS |
+| HKEYS | HSCAN | ACL WHOAMI |
+| HGET | INCR | BGREWRITEAOF |
+| HGETALL | INFO | BGSAVE |
+| HINCRBY | MSET | BITFIELD
+| HINCRBYFLOAT | MSETNX | BLPOP |
+| HMGET | PSETEX | BRPOP |
+| HMSET | SCAN | BRPOPLPUSH | |
+| HSCAN | SCARD | BZPOPMAX |
+| HSET | SDIFF | BZPOPMIN |
+| HSETNX | SDIFFSTORE | CLIENT CACHING |
+| HSTRLEN | SELECT | CLIENT GETNAME |
+| HLEN | SETBIT | CLIENT GETREDIR |
+| HVALS | SETEX | CLIENT ID
+| INCRBY | SETRANGE | CLIENT KILL |
+| INCRBYFLOAT | SHUTDOWN | CLIENT LIST |
+| KEYS | SINTER | CLIENT PAUSE |
+| MGET | SINTERSTORE | CLIENT REPLY |
+| PERSIST | SISMEMBER | CLIENT SETNAME |
+| PEXPIRE | SLOWLOG | CLIENT TRACKING |
+| PEXPIREAT | SMOVE | CLIENT UNBLOCK |
+| PING | SPOP | CLUSTER ADDSLOTS |
+| PSUBSCRIBE | SRANDMEMBER | CLUSTER BUMPEPOCH
+| PTTL | SSCAN | CLUSTER COUNT-FAILURE-REPORTS |
+| PUBLISH | SUNION | CLUSTER COUNTKEYSINSLOT |
+| PUNSUBSCRIBE | SUNIONSTORE | CLUSTER DELSLOTS |
+| QUIT | TIME | CLUSTER FAILOVER |
+| RENAME | UNLINK [1] | CLUSTER FLUSHSLOTS |
+| SADD | CLUSTER FORGET |
+| SET | CLUSTER GETKEYSINSLOT |
+| SETNX | CLUSTER INFO |
+| SMEMBERS | CLUSTER KEYSLOT |
+| SREM | CLUSTER MEET |
Review comment:
Because some of the `|` characters were not added back here, the `CLUSTER FORGET` through `CLUSTER MEET` commands are in the Unsupported column.
##########
File path: geode-redis/README.md
##########
@@ -159,54 +159,54 @@ start server \
|-----------------------|-------------------------------------------------------|-----------------------------------|
| APPEND | BITCOUNT | ACL CAT |
| AUTH | BITOP | ACL DELUSER |
-| DEL | BITPOS | ACL GENPASS |
-| EXISTS | DBSIZE | ACL GETUSER |
-| EXPIRE | DECR | ACL HELP |
-| EXPIREAT | DECRBY | ACL LIST |
-| GET | ECHO | ACL LOAD |
-| HGETALL | FLUSHALL | ACL LOG |
-| HMGET | FLUSHDB | ACL SAVE |
-| HMSET | GETBIT | ACL SETUSER |
-| HSET | GETRANGE | ACL USERS |
-| HSETNX | GETSET | ACL WHOAMI |
-| HSTRLEN | HDEL | BGREWRITEAOF |
-| HLEN | HEXISTS | BGSAVE |
-| HVALS | HGET | BITFIELD |
-| KEYS | HINCRBY | BLPOP |
-| PERSIST | HINCRBYFLOAT | BRPOP |
-| PEXPIRE | HKEYS | BRPOPLPUSH |
-| PEXPIREAT | HSCAN | BZPOPMAX |
-| PING | INCR | BZPOPMIN |
-| PSUBSCRIBE | INCRBY | CLIENT CACHING |
-| PTTL | INCRBYFLOAT | CLIENT GETNAME |
-| PUBLISH | INFO | CLIENT GETREDIR |
-| PUNSUBSCRIBE | MGET | CLIENT ID |
-| QUIT | MSET | CLIENT KILL |
-| RENAME | MSETNX | CLIENT LIST |
-| SADD | PSETEX | CLIENT PAUSE |
-| SET | SCAN | CLIENT REPLY |
-| SMEMBERS | SCARD | CLIENT SETNAME |
-| SREM | SDIFF | CLIENT TRACKING |
-| SUBSCRIBE | SDIFFSTORE | CLIENT UNBLOCK |
-| TTL | SELECT | CLUSTER ADDSLOTS |
-| TYPE | SETBIT | CLUSTER BUMPEPOCH |
-| UNSUBSCRIBE | SETEX | CLUSTER COUNT-FAILURE-REPORTS |
-| | SETNX | CLUSTER COUNTKEYSINSLOT |
-| | SETRANGE | CLUSTER DELSLOTS |
-| | SHUTDOWN | CLUSTER FAILOVER |
-| | SINTER | CLUSTER FLUSHSLOTS |
-| | SINTERSTORE | CLUSTER FORGET |
-| | SISMEMBER | CLUSTER GETKEYSINSLOT |
-| | SLOWLOG | CLUSTER INFO |
-| | SMOVE | CLUSTER KEYSLOT |
-| | SPOP | CLUSTER MEET |
-| | SRANDMEMBER | CLUSTER MYID |
-| | SSCAN | CLUSTER NODES |
-| | STRLEN | CLUSTER REPLICAS |
-| | SUNION | CLUSTER REPLICATE |
-| | SUNIONSTORE | CLUSTER RESET |
-| | TIME | CLUSTER SAVECONFIG |
-| | UNLINK [1] | CLUSTER SET-CONFIG-EPOCH |
+| DECR | BITPOS | ACL GENPASS |
+| DEL | DBSIZE | ACL GETUSER |
+| EXISTS | DECRBY | ACL HELP |
+| EXPIRE | ECHO | ACL LIST |
+| EXPIREAT | FLUSHALL | ACL LOAD |
+| GET | FLUSHDB | ACL LOG |
+| GETRANGE | GETBIT | ACL SAVE |
+| HDEL | GETSET | ACL SETUSER |
+| HEXISTS | HINCRBY | ACL USERS |
+| HKEYS | HSCAN | ACL WHOAMI |
+| HGET | INCR | BGREWRITEAOF |
Review comment:
`INCR` should be moved from the Unsupported column to the Supported column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org