You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@distributedlog.apache.org by khurrumnasimm <gi...@git.apache.org> on 2016/10/21 09:39:06 UTC

[GitHub] incubator-distributedlog pull request #41: DL-4: Repackage the source under ...

GitHub user khurrumnasimm opened a pull request:

    https://github.com/apache/incubator-distributedlog/pull/41

    DL-4: Repackage the source under apache namespace

    Repackage the source code from 'com.twitter.distributedlog' to 'org.apache.distributedlog'.
    
    It is a huge change, but I basically just renamed the files and changed the package name. Let me know if it is okay.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khurrumnasimm/incubator-distributedlog kn/repackaging

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-distributedlog/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
    
----
commit 7e7a61e169a42064c57aa5ddca555e34e0c1cc09
Author: Khurrum Nasim <kh...@gmail.com>
Date:   2016-10-21T08:41:23Z

    Move files from com/twitter/distributedlog to org/apache/distributedlog

commit 385fab66cc2c8126883f11c3c993daf9f4e656a9
Author: Khurrum Nasim <kh...@gmail.com>
Date:   2016-10-21T09:02:21Z

    Rename package from 'com.twitter.distributedlog' to 'org.apache.distributedlog'

commit d53228276212d4cf1b093363a405271b5fcc44b1
Author: Khurrum Nasim <kh...@gmail.com>
Date:   2016-10-21T09:03:33Z

    Add a script to rename the package

commit 8f91bcae1bd7aa883cb8f9bc98dae2580ca52d67
Author: Khurrum Nasim <kh...@gmail.com>
Date:   2016-10-21T09:09:28Z

    rename the package in the findbugs xml files

commit 91cd714d457230a665ba029176e97ac7dc9f06aa
Author: Khurrum Nasim <kh...@gmail.com>
Date:   2016-10-21T09:13:15Z

    Add apache license header

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

Posted by sijie <gi...@git.apache.org>.

Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/41
  
    @khurrumnasimm sorry for being late. the change LGTM. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

Posted by leighst <gi...@git.apache.org>.

Github user leighst commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/41
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

Posted by sijie <gi...@git.apache.org>.

Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/41
  
    @khurrumnasimm we almost finished merging changes back to the master branch. I would like to proceed with this pull request next week and cut the first release candidate. if you have the script for repackaging the whole project, can you share the script?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

Posted by khurrumnasimm <gi...@git.apache.org>.

Github user khurrumnasimm commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/41
  
    ping again @leighst @sijie 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

Posted by sijie <gi...@git.apache.org>.

Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/41
  
    @khurrumnasimm thank you so much for your effort. This is not a trivial change. I think most of changes are just renaming files and package names. so +1 from me. 
    
    but I'd like to see what other people's opinion. @leighst ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

Posted by khurrumnasimm <gi...@git.apache.org>.

Github user khurrumnasimm commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/41
  
    @sijie I added a script "scripts/dev/repackage.sh". it is included in this pull request.
    
    I think the easiest way to coordinate with this pull request - when you guys merge this pull request, you can run the script to repackage the files. what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

Posted by sijie <gi...@git.apache.org>.

Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/41
  
    @leighst @khurrumnasimm I would like to put this as last change to merge for the first apache release. since we might have quite a few changes to merge based on current package name.
    
    @khurrumnasimm do you have any script for repacking this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---