You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "smjn (via GitHub)" <gi...@apache.org> on 2025/02/16 16:52:08 UTC

[PR] KAFKA-18809: Set min in sync replicas for __share_group_state. [kafka]

smjn opened a new pull request, #18922:
URL: https://github.com/apache/kafka/pull/18922

   * The `share.coordinator.state.topic.min.isr` config defined in `ShareCoordinatorConfig` was not being used in the `AutoTopicCreationManager`. 
   * The `AutoTopicCreationManager` calls the `ShareCoordinatorService.shareGroupStateTopicConfigs` to configs for the topic to create.
   * The method `ShareCoordinatorService.shareGroupStateTopicConfigs` was not setting the supplied config value for `share.coordinator.state.topic.min.isr` to `min.insync.replicas`.
   * In this PR, we remedy the situation by setting the value.
   * A test has been added to `ShareCoordinatorServiceTest` so that this is not repeated for any configs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-18809: Set min in sync replicas for __share_group_state. [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #18922:
URL: https://github.com/apache/kafka/pull/18922


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org