You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/17 11:24:17 UTC
[GitHub] [apisix] kwanhur opened a new pull request #6357: ci(prove): support ignore specified test cases
kwanhur opened a new pull request #6357:
URL: https://github.com/apache/apisix/pull/6357
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
support to ignore test cases in `t` by specified directory or files.
import env variable `APISIX_PROVE_IGNORED_DIR`, could preserve it in workflow job steps.
test case `ignore t/plugin` just cost about 30min, [details](https://github.com/kwanhur/apisix/actions/runs/1857890276)
<!--- If it fixes an open issue, please link to the issue here. -->
#5861
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on pull request #6357: ci(prove): support ignore specified test cases
Posted by GitBox <gi...@apache.org>.
kwanhur commented on pull request #6357:
URL: https://github.com/apache/apisix/pull/6357#issuecomment-1043823553
ok, this PR not the correct way to solve problem, I'll close it :-)
Still pleasure to discuss in #5861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur closed pull request #6357: ci(prove): support ignore specified test cases
Posted by GitBox <gi...@apache.org>.
kwanhur closed pull request #6357:
URL: https://github.com/apache/apisix/pull/6357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #6357: ci(prove): support ignore specified test cases
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #6357:
URL: https://github.com/apache/apisix/pull/6357#issuecomment-1043712263
We are planning to **split** the test, not **ignore** the test. There are two different things... Such a solution doesn't solve the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #6357: ci(prove): support ignore specified test cases
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #6357:
URL: https://github.com/apache/apisix/pull/6357#issuecomment-1043733078
And please stop bombarding the reviewers with PRs only having a few lines modified. This PR doesn't bring any difference at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #6357: ci(prove): support ignore specified test cases
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #6357:
URL: https://github.com/apache/apisix/pull/6357#issuecomment-1044387530
Great. Please show us your plan next time before hurrying up a solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org