You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/10/08 02:13:57 UTC
Review Request 26431: Moving post_drain script execution into
host_maintenance.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/
-----------------------------------------------------------
Review request for Aurora, Joe Smith and Mark Chu-Carroll.
Bugs: AURORA-806
https://issues.apache.org/jira/browse/AURORA-806
Repository: aurora
Description
-------
Moving post_drain script functionality into host_maintenance.py to support per batch execution.
Diffs
-----
src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e
src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388
src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8
src/test/python/apache/aurora/client/commands/test_maintenance.py d86aaf677804301fa5ddf1f76dba552f4fafb8c3
Diff: https://reviews.apache.org/r/26431/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 26431: Moving post_drain script execution into
host_maintenance.py
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review56561
-----------------------------------------------------------
Mark?
- Maxim Khutornenko
On Oct. 8, 2014, 11:46 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26431/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 11:46 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-806
> https://issues.apache.org/jira/browse/AURORA-806
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moving post_drain script functionality into host_maintenance.py to support per batch execution.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e
> src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388
> src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8
>
> Diff: https://reviews.apache.org/r/26431/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26431: Moving post_drain script execution into
host_maintenance.py
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/
-----------------------------------------------------------
(Updated Oct. 17, 2014, 8:02 p.m.)
Review request for Aurora, Joe Smith and Mark Chu-Carroll.
Changes
-------
Rebasing.
Bugs: AURORA-806
https://issues.apache.org/jira/browse/AURORA-806
Repository: aurora
Description
-------
Moving post_drain script functionality into host_maintenance.py to support per batch execution.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/host_maintenance.py 697de4b2ec4ffbaaa17650eed407c4e85c5b902c
src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388
src/test/python/apache/aurora/admin/test_host_maintenance.py 246081ad9520d0435a5247206e14831d27bb556d
Diff: https://reviews.apache.org/r/26431/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 26431: Moving post_drain script execution into
host_maintenance.py
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review55911
-----------------------------------------------------------
Ship it!
Thanks!
- Joe Smith
On Oct. 8, 2014, 4:46 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26431/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 4:46 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-806
> https://issues.apache.org/jira/browse/AURORA-806
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moving post_drain script functionality into host_maintenance.py to support per batch execution.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e
> src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388
> src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8
>
> Diff: https://reviews.apache.org/r/26431/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26431: Moving post_drain script execution into
host_maintenance.py
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review56076
-----------------------------------------------------------
Ping, Mark.
- Maxim Khutornenko
On Oct. 8, 2014, 11:46 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26431/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 11:46 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-806
> https://issues.apache.org/jira/browse/AURORA-806
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moving post_drain script functionality into host_maintenance.py to support per batch execution.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e
> src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388
> src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8
>
> Diff: https://reviews.apache.org/r/26431/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26431: Moving post_drain script execution into
host_maintenance.py
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review57177
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On Oct. 8, 2014, 7:46 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26431/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 7:46 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-806
> https://issues.apache.org/jira/browse/AURORA-806
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moving post_drain script functionality into host_maintenance.py to support per batch execution.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e
> src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388
> src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8
>
> Diff: https://reviews.apache.org/r/26431/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26431: Moving post_drain script execution into
host_maintenance.py
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/
-----------------------------------------------------------
(Updated Oct. 8, 2014, 11:46 p.m.)
Review request for Aurora, Joe Smith and Mark Chu-Carroll.
Changes
-------
CR comments.
Bugs: AURORA-806
https://issues.apache.org/jira/browse/AURORA-806
Repository: aurora
Description
-------
Moving post_drain script functionality into host_maintenance.py to support per batch execution.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e
src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388
src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8
Diff: https://reviews.apache.org/r/26431/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 26431: Moving post_drain script execution into
host_maintenance.py
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Oct. 8, 2014, 7:08 p.m., Joe Smith wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 117
> > <https://reviews.apache.org/r/26431/diff/1/?file=715028#file715028line117>
> >
> > can this be a mock that we assert gets called 3 times?
> >
> > (This test is a little bit of an integration test since it goes in and is also testing perform_maintenace, but a full refactor of this test may be too much for now)
Sure, reverted it.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review55859
-----------------------------------------------------------
On Oct. 8, 2014, 12:13 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26431/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 12:13 a.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-806
> https://issues.apache.org/jira/browse/AURORA-806
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moving post_drain script functionality into host_maintenance.py to support per batch execution.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e
> src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388
> src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8
> src/test/python/apache/aurora/client/commands/test_maintenance.py d86aaf677804301fa5ddf1f76dba552f4fafb8c3
>
> Diff: https://reviews.apache.org/r/26431/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26431: Moving post_drain script execution into
host_maintenance.py
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review55859
-----------------------------------------------------------
src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/26431/#comment96235>
can this be a mock that we assert gets called 3 times?
(This test is a little bit of an integration test since it goes in and is also testing perform_maintenace, but a full refactor of this test may be too much for now)
- Joe Smith
On Oct. 7, 2014, 5:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26431/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 5:13 p.m.)
>
>
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
>
>
> Bugs: AURORA-806
> https://issues.apache.org/jira/browse/AURORA-806
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moving post_drain script functionality into host_maintenance.py to support per batch execution.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e
> src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388
> src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8
> src/test/python/apache/aurora/client/commands/test_maintenance.py d86aaf677804301fa5ddf1f76dba552f4fafb8c3
>
> Diff: https://reviews.apache.org/r/26431/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>