[GitHub] [hadoop] vinayakumarb edited a comment on issue #1635: HADOOP-16596. [pb-upgrade] Use shaded protobuf classes from hadoop-thirdparty dependency

[GitBox <gi...@apache.org>]

vinayakumarb edited a comment on issue #1635: HADOOP-16596. [pb-upgrade] Use shaded protobuf classes from hadoop-thirdparty dependency
URL: https://github.com/apache/hadoop/pull/1635#issuecomment-574026638
 
 
   ### Summary of changes
   #### Using hadoop-shaded-protobuf_3_7 artifact
   * Using 1.0.0-SNAPSHOT version of hadoop-shaded-protobuf_3_7 artifact from hadoop-thirdparty
     Will be replaced with release artifact version once released in follow-up task.
   #### replacer plugin to replace tokens (com.google.protobuf to o.a.h.thirdparty.protobuf_3_7)
   * Configured replacer plugin to replace tokens in generated-sources, generated-test-sources, sources , test-sources in hadoop-project/pom.xml.
   * All these executions of replacer plugin skip by default, and each module wherever protobuf is used these executions will be turned on.
   * Changed files due to replacer execution of source and test-sources  are committed. And some files are manually edited to fix checkstyle comments due to line length.
   * **This replacement should be done for all modules together due to high inter dependency**
   #### Restored *protobuf.version* property to 2.5.0 and added to classpath.
   * adding back 2.5.0 protobuf into classpath fixes the hbase timelineserver tests.
   * No classes of protobuf 2.5.0 will be referred by Hadoop code any more. So this jar just stays back not to break downstream classpath
   #### Increased timeout in Jenkinsfile
   * Increased the timeout to 16 hours to avoid build gets aborted in cases changes are in root directory of hadoop code base. This can be reverted if not required to commit.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org