You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Roland Weber (JIRA)" <ji...@apache.org> on 2007/12/28 18:38:43 UTC
[jira] Created: (HTTPCLIENT-725) TSCCM code cleanup
TSCCM code cleanup
------------------
Key: HTTPCLIENT-725
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-725
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: HttpConn
Reporter: Roland Weber
Assignee: Roland Weber
Priority: Minor
Fix For: 4.0 Alpha 3
The ThreadSafeClientConnectionManager, or rather it's ConnPoolByRoute, needs plenty of cleanup.
- use long + TimeUnit for timeout intervals (Java 5 style)
- compute timeout end date once instead of remaining interval
- review which methods should acquire the pool lock,
and which should expect the caller to have done that
- use factory methods to instantiate some of the helper objects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-725) TSCCM code cleanup
Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554926 ]
Roland Weber commented on HTTPCLIENT-725:
-----------------------------------------
most items taken care of, only the locking review is pending
> TSCCM code cleanup
> ------------------
>
> Key: HTTPCLIENT-725
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-725
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpConn
> Reporter: Roland Weber
> Assignee: Roland Weber
> Priority: Minor
> Fix For: 4.0 Alpha 3
>
>
> The ThreadSafeClientConnectionManager, or rather it's ConnPoolByRoute, needs plenty of cleanup.
> - use long + TimeUnit for timeout intervals (Java 5 style)
> - compute timeout end date once instead of remaining interval
> - review which methods should acquire the pool lock,
> and which should expect the caller to have done that
> - use factory methods to instantiate some of the helper objects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Resolved: (HTTPCLIENT-725) TSCCM code cleanup
Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roland Weber resolved HTTPCLIENT-725.
-------------------------------------
Resolution: Fixed
I'll leave the locking as it is for now.
cheers,
Roland
> TSCCM code cleanup
> ------------------
>
> Key: HTTPCLIENT-725
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-725
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpConn
> Reporter: Roland Weber
> Assignee: Roland Weber
> Priority: Minor
> Fix For: 4.0 Alpha 3
>
>
> The ThreadSafeClientConnectionManager, or rather it's ConnPoolByRoute, needs plenty of cleanup.
> - use long + TimeUnit for timeout intervals (Java 5 style)
> - compute timeout end date once instead of remaining interval
> - review which methods should acquire the pool lock,
> and which should expect the caller to have done that
> - use factory methods to instantiate some of the helper objects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org