You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/11/16 18:17:00 UTC
[jira] [Work logged] (ARTEMIS-2991) Leak of HttpAcceptorHandler
instances when using websocket connections
[ https://issues.apache.org/jira/browse/ARTEMIS-2991?focusedWorklogId=512490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-512490 ]
ASF GitHub Bot logged work on ARTEMIS-2991:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/20 18:16
Start Date: 16/Nov/20 18:16
Worklog Time Spent: 10m
Work Description: ldebello commented on pull request #3339:
URL: https://github.com/apache/activemq-artemis/pull/3339#issuecomment-728236906
> @ldebello, 2.16.0 has already been released. The release announcement was sent to the ActiveMQ User List. You can find the announcement in the [list archive](http://mail-archives.apache.org/mod_mbox/activemq-users/202011.mbox/%3CCAKF%2BbsrKmN%3D0WbfQgUcbPz5558WiaBPZJe9bHUF%3D2Gh5t%3DbTAg%40mail.gmail.com%3E). The download is available [here](http://activemq.apache.org/components/artemis/download/).
>
> If you really want/need this fix you can always download the tag of 2.16.0, apply this fix, and either build a full release (e.g. using `mvn clean install -Prelease` or just build the jar for the `activemq-server` module and drop that in to your existing environment.
>
> As far as this PR goes you need to squash your commits and then reference ARTEMIS-2991 in the commit message as described in the [hacking guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#commitMessageDetails).
Thanks for the response, I have already squash the commits and change the message, thanks for the help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 512490)
Remaining Estimate: 0h
Time Spent: 10m
> Leak of HttpAcceptorHandler instances when using websocket connections
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-2991
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2991
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.9.0, 2.10.0, 2.10.1, 2.11.0, 2.12.0, 2.13.0, 2.14.0, 2.15.0, 2.16.0
> Reporter: Luis Miguel De Bello
> Priority: Major
> Fix For: 2.17.0
>
> Attachments: HeapDump analysis.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We are running Artemis 2.9.0 and we noticed the memory grows continuously after getting a heap we discovered there are a leak of multiple instances of type org.apache.activemq.artemis.core.remoting.impl.netty.HttpAcceptorHandler which are keep in a list inside org.apache.activemq.artemis.core.remoting.impl.netty.HttpKeepAliveRunnable.
>
> Those instances are removed in the channelInactive method but this method is not called because when doing the upgrade to websocket the handler is removed.
>
> Proposals:
> 1) In the upgrade clean up the reference for the HttpAcceptorHandler before removing the handler.
> 2) If option 1 does not work because that threads also send the keep alive for websocket, I could use the channelInactive from websocket handler to later unregister the handler
--
This message was sent by Atlassian Jira
(v8.3.4#803005)