[GitHub] [sling-org-apache-sling-discovery-oak] ashokmca07 commented on pull request #9: SLING-11355: sling discovery bundles: update to sling 48

[GitBox <gi...@apache.org>]

ashokmca07 commented on PR #9:
URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/9#issuecomment-1194538278

   > Generally lgtm, just added 1 comment that I think might be worth looking at.
   > 
   > Also, not sure if that should be a worry or not: if I compile with java 8 then things work fine, with java 11 I get
   > 
   > ```
   > [ERROR] org.apache.sling.discovery.oak.TopologyWebConsolePluginTest.testResourceResolverFactory  Time elapsed: 11.354 s  <<< ERROR!
   > java.lang.ExceptionInInitializerError
   > 	at org.apache.jackrabbit.core.query.AQTQueryFactory.getSupportedLanguages(AQTQueryFactory.java:34)
   > ...
   > Caused by: java.lang.IllegalArgumentException: org.apache.jackrabbit.spi.commons.query.QueryTreeBuilder is not an ImageIO SPI class
   > 	at java.desktop/javax.imageio.spi.ServiceRegistry.checkClassAllowed(ServiceRegistry.java:722)
   > 	at java.desktop/javax.imageio.spi.ServiceRegistry.lookupProviders(ServiceRegistry.java:170)
   > 	at org.apache.jackrabbit.spi.commons.query.QueryTreeBuilderRegistry.<clinit>(QueryTreeBuilderRegistry.java:55)
   > ```
   > 
   > But I think it might be unrelated (will recheck)
   
   @stefan-egli you are right, it was breaking because of `org.apache.sling.commons.testing` which is still pointing to old jackrabbit version. but It should work now, could you please give a try again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org