[jira] [Commented] (PARQUET-1984) Some tests fail on windows

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286439#comment-17286439 ] 

ASF GitHub Bot commented on PARQUET-1984:
-----------------------------------------

fschmalzel opened a new pull request #870:
URL: https://github.com/apache/parquet-mr/pull/870


   Check for \r\n lineendings instead of \n
   Change file layout (backslash and slash) to check
   Close files / streams before deleting file
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET-1984) issue.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: It fixes tests for the windows platform.
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Some tests fail on windows
> --------------------------
>
>                 Key: PARQUET-1984
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1984
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-mr, parquet-thrift
>    Affects Versions: 1.12.0
>         Environment: Windows 10
>            Reporter: Felix Schmalzel
>            Priority: Minor
>
> Reasons:
>  * Expecting \n and getting \r\n
>  * Unclosed streams preventing a temporary file from being deleted
>  * File layout differences \ and /
>  * No native library for brotli, because the brotli-codec dependency only shadows macos and linux native libraries.
>  
> I've already developed a patch that would fix all the problems excluding the brotli one. For that one we would have to wait until this [https://github.com/rdblue/brotli-codec/pull/2] request is merged. I will link the merge request for the other problems in the next few days.
> Is there a related ticket that i have overlooked?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)