You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/23 15:11:00 UTC

[GitHub] [arrow] iajoiner commented on a change in pull request #12231: ARROW-14783: [C++][Python] Fix the BytesIO support issue

iajoiner commented on a change in pull request #12231:
URL: https://github.com/apache/arrow/pull/12231#discussion_r790289895



##########
File path: cpp/src/arrow/adapters/orc/adapter.cc
##########
@@ -720,11 +720,7 @@ class ArrowOutputStream : public liborc::OutputStream {
     return filename;
   }
 
-  void close() override {
-    if (!output_stream_.closed()) {
-      ORC_THROW_NOT_OK(output_stream_.Close());
-    }
-  }
+  void close() override {}

Review comment:
       No. What ORC does is writing the content. https://github.com/apache/orc/blob/7e12a8ccac81548fde6e5d0538da2e68c77df601/c%2B%2B/src/Writer.cc#L369




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org