You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/12/20 21:39:18 UTC
[GitHub] [pulsar] vzhikserg opened a new pull request #5911: Remove
duplicated lombok annotations in the pulsar-io modules
vzhikserg opened a new pull request #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911
### Motivation
Most of the configuration classes of the connectors had the following annotations:
```
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
```
The [@Data](https://projectlombok.org/features/Data) annotation includes all other annotations:
> All together now: A shortcut for @ToString, @EqualsAndHashCode, @Getter on all fields, @Setter on all non-final fields, and @RequiredArgsConstructor!
### Modifications
Removed `@Setter`, `@Getter`, `@EqualsAndHashCode`, and '@ToString' if the `@Data` annotation was also present
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] vzhikserg removed a comment on issue #5911: Remove
duplicated lombok annotations in the pulsar-io modules
Posted by GitBox <gi...@apache.org>.
vzhikserg removed a comment on issue #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911#issuecomment-569298796
run cpp tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5911: Remove duplicated lombok
annotations in the pulsar-io modules
Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911#issuecomment-569920639
run cpp tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5911: Remove duplicated lombok
annotations in the pulsar-io modules
Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911#issuecomment-569920359
run cpp tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5911: Remove duplicated lombok
annotations in the pulsar-io modules
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911#issuecomment-568630171
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5911: Remove duplicated lombok
annotations in the pulsar-io modules
Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911#issuecomment-569920860
run cpp tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5911: Remove duplicated lombok
annotations in the pulsar-io modules
Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911#issuecomment-569915482
run cpp tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] vzhikserg commented on issue #5911: Remove duplicated
lombok annotations in the pulsar-io modules
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on issue #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911#issuecomment-569298796
run cpp tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5911: Remove duplicated lombok
annotations in the pulsar-io modules
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911#issuecomment-568835113
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie merged pull request #5911: Remove duplicated lombok
annotations in the pulsar-io modules
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] vzhikserg commented on issue #5911: Remove duplicated
lombok annotations in the pulsar-io modules
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on issue #5911: Remove duplicated lombok annotations in the pulsar-io modules
URL: https://github.com/apache/pulsar/pull/5911#issuecomment-569433439
run cpp tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services