You are viewing a plain text version of this content. The canonical link for it is here.

Posted to cvs@httpd.apache.org by ji...@apache.org on 2005/04/25 20:27:15 UTC

svn commit: r164618 - /httpd/httpd/branches/2.0.x/STATUS

Author: jim
Date: Mon Apr 25 11:27:15 2005
New Revision: 164618

URL: http://svn.apache.org/viewcvs?rev=164618&view=rev
Log:
Note quick hack, but it means we use some "hidden" knowledge.

Modified:
    httpd/httpd/branches/2.0.x/STATUS

Modified: httpd/httpd/branches/2.0.x/STATUS
URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/2.0.x/STATUS?rev=164618&r1=164617&r2=164618&view=diff
==============================================================================
--- httpd/httpd/branches/2.0.x/STATUS (original)
+++ httpd/httpd/branches/2.0.x/STATUS Mon Apr 25 11:27:15 2005
@@ -98,6 +98,11 @@
     *) ap_proxy_canonenc() is over-eager in handling '%' for reverse
        proxies (PR: 29554).
          http://svn.apache.org/viewcvs.cgi?rev=151153&view=rev
+            - or (quick hack) -
+         Index: modules/proxy/proxy_util.c
+             -       if (isenc && ch == '%') {
+             +       if (isenc && (isenc != PROXYREQ_REVERSE) && ch == '%') {
+
        +1: jim
 
     *) several changes to improve logging of connection-oriented errors, including

Re: svn commit: r164618 - /httpd/httpd/branches/2.0.x/STATUS

Posted by Joe Orton <jo...@redhat.com>.

On Mon, Apr 25, 2005 at 06:27:15PM -0000, Jim Jagielski wrote:
> Author: jim
> Date: Mon Apr 25 11:27:15 2005
> New Revision: 164618
> 
> URL: http://svn.apache.org/viewcvs?rev=164618&view=rev
> Log:
> Note quick hack, but it means we use some "hidden" knowledge.
> 
> Modified:
>     httpd/httpd/branches/2.0.x/STATUS
> 
> Modified: httpd/httpd/branches/2.0.x/STATUS
> URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/2.0.x/STATUS?rev=164618&r1=164617&r2=164618&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.0.x/STATUS (original)
> +++ httpd/httpd/branches/2.0.x/STATUS Mon Apr 25 11:27:15 2005
> @@ -98,6 +98,11 @@
>      *) ap_proxy_canonenc() is over-eager in handling '%' for reverse
>         proxies (PR: 29554).
>           http://svn.apache.org/viewcvs.cgi?rev=151153&view=rev
> +            - or (quick hack) -
> +         Index: modules/proxy/proxy_util.c
> +             -       if (isenc && ch == '%') {
> +             +       if (isenc && (isenc != PROXYREQ_REVERSE) && ch == '%') {
> +

Well, which is it you're proposing, all that stuff in rev 151153 or some
one-line change?  All I want to review in a backport proposal is a
single "diff -u" format patch which I can apply to mod_proxy in the
2.0.x branch and then run tests.  You're not making it easy for anyone
here ;)

joe