You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/11 18:43:22 UTC

[GitHub] [superset] eschutho commented on pull request #13032: refactor: HighlightedSql into functional component

eschutho commented on pull request #13032:
URL: https://github.com/apache/superset/pull/13032#issuecomment-777706179


   > > I'll do another manual qa when you're ready.
   > 
   > Hello, I think I am ready. Would it be ok if I kept the ternary? Or is it better with the logical and?
   
   Is this working? `{(rawSql && rawSql !== sql) && (` It would make more sense than returning null. If you don't have a second value, then a ternary is a little strange. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org