You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/07 08:20:40 UTC

[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #533: chore: Set permissions for GitHub actions

slawekjaranowski commented on code in PR #533:
URL: https://github.com/apache/maven-surefire/pull/533#discussion_r867322913


##########
.github/workflows/maven-verify.yml:
##########
@@ -21,8 +21,13 @@ on:
   push:
   pull_request:
 
+permissions:
+  contents: read
+

Review Comment:
   why read on this level?



##########
.github/workflows/maven-verify.yml:
##########
@@ -21,8 +21,13 @@ on:
   push:
   pull_request:
 
+permissions:
+  contents: read
+
 jobs:
   build:
+    permissions:
+      contents: none

Review Comment:
   and next set to none ... why not on global level?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org