[GitHub] [kafka] machi1990 commented on a diff in pull request #13712: KAFKA-14133: Migrate Admin mock in TaskManagerTest to Mockito

["machi1990 (via GitHub)" <gi...@apache.org>]

machi1990 commented on code in PR #13712:
URL: https://github.com/apache/kafka/pull/13712#discussion_r1192833508


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -3778,17 +3777,13 @@ public Map<TopicPartition, Long> purgeableOffsets() {
 
         purgableOffsets.put(t1p1, 17L);
         taskManager.maybePurgeCommittedRecords();
-
-        verify(adminClient);

Review Comment:
   This line is removed, and I wonder whether we should add a similar assertion for the `adminClient` mock after each of these two calls: https://github.com/apache/kafka/blob/ff6b6dd601d9a6156dba249a8b52201a34eaca13/streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java#L3775-L3779
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org