You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/05 00:26:42 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36767: [SPARK-39363][K8S] Deprecate k8s memory overhead and make it optional

dongjoon-hyun commented on code in PR #36767:
URL: https://github.com/apache/spark/pull/36767#discussion_r889629576


##########
core/src/main/scala/org/apache/spark/SparkConf.scala:
##########
@@ -638,7 +638,9 @@ private[spark] object SparkConf extends Logging {
       DeprecatedConfig("spark.blacklist.killBlacklistedExecutors", "3.1.0",
         "Please use spark.excludeOnFailure.killExcludedExecutors"),
       DeprecatedConfig("spark.yarn.blacklist.executor.launch.blacklisting.enabled", "3.1.0",
-        "Please use spark.yarn.executor.launch.excludeOnFailure.enabled")
+        "Please use spark.yarn.executor.launch.excludeOnFailure.enabled"),
+        DeprecatedConfig("spark.kubernetes.memoryOverheadFactor", "3.4.0",

Review Comment:
   indentation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org