[rocketmq] branch develop updated: Persist consumer offset should not be disabled when auto commit is turned off (#5635)

[os...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

osgooli pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new 80b63ab1d Persist consumer offset should not be disabled when auto commit is turned off (#5635)
80b63ab1d is described below

commit 80b63ab1d7c0dc04e60f84c6b2586ec0d4a942bc
Author: rongtong <ji...@163.com>
AuthorDate: Fri Dec 2 16:27:05 2022 +0800

    Persist consumer offset should not be disabled when auto commit is turned off (#5635)
    
    Co-authored-by: SSpirits <ad...@lv5.moe>
---
 .../rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java    | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
index 498c3e360..a5712008c 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
@@ -1111,10 +1111,6 @@ public class DefaultLitePullConsumerImpl implements MQConsumerInner {
 
     @Override
     public void persistConsumerOffset() {
-        // this method will be called by MQInstance schedule task, commit offset depends on autocommit config
-        if (!this.defaultLitePullConsumer.isAutoCommit()) {
-            return;
-        }
         try {
             checkServiceState();
             Set<MessageQueue> mqs = new HashSet<>();