You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by du...@apache.org on 2023/12/04 06:40:56 UTC
(shardingsphere) branch master updated: Remove unused method of findGenerateKeyExpressions (#29272)
This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 77390389f73 Remove unused method of findGenerateKeyExpressions (#29272)
77390389f73 is described below
commit 77390389f73b59b5106a04bfef9d0b241b04a88d
Author: ZhangCheng <ch...@apache.org>
AuthorDate: Mon Dec 4 14:40:50 2023 +0800
Remove unused method of findGenerateKeyExpressions (#29272)
* Remove unused method of findGenerateKeyExpressions
* Remove unused method of findGenerateKeyExpressions
---
.../insert/keygen/engine/GeneratedKeyContextEngine.java | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/segment/insert/keygen/engine/GeneratedKeyContextEngine.java b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/segment/insert/keygen/engine/GeneratedKeyContextEngine.java
index 356b713910d..478df7cf50c 100644
--- a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/segment/insert/keygen/engine/GeneratedKeyContextEngine.java
+++ b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/segment/insert/keygen/engine/GeneratedKeyContextEngine.java
@@ -29,8 +29,6 @@ import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr.simple.P
import org.apache.shardingsphere.sql.parser.sql.common.statement.dml.InsertStatement;
import org.apache.shardingsphere.sql.parser.sql.dialect.handler.dml.InsertStatementHandler;
-import java.util.Collection;
-import java.util.LinkedList;
import java.util.List;
import java.util.Optional;
@@ -48,7 +46,7 @@ public final class GeneratedKeyContextEngine {
* Create generate key context.
*
* @param insertColumnNames insert column names
- * @param insertValueContexts value expressions
+ * @param insertValueContexts insert value contexts
* @param params SQL parameters
* @return generate key context
*/
@@ -109,14 +107,6 @@ public final class GeneratedKeyContextEngine {
return result;
}
- private Collection<ExpressionSegment> findGenerateKeyExpressions(final List<String> insertColumnNames, final List<List<ExpressionSegment>> valueExpressions, final String generateKeyColumnName) {
- Collection<ExpressionSegment> result = new LinkedList<>();
- for (List<ExpressionSegment> each : valueExpressions) {
- result.add(each.get(findGenerateKeyIndex(insertColumnNames, generateKeyColumnName.toLowerCase())));
- }
- return result;
- }
-
private int findGenerateKeyIndex(final List<String> insertColumnNames, final String generateKeyColumnName) {
return insertColumnNames.isEmpty() ? schema.getVisibleColumnNames(insertStatement.getTable().getTableName().getIdentifier().getValue()).indexOf(generateKeyColumnName)
: insertColumnNames.indexOf(generateKeyColumnName);