You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/06 09:55:39 UTC

[GitHub] [pulsar] Demogorgon314 opened a new pull request, #15951: [fix][client] Fix NPE when TableView handles null value message

Demogorgon314 opened a new pull request, #15951:
URL: https://github.com/apache/pulsar/pull/15951

   ### Motivation
   
   Currently, when we publish a null value message([tombstones](https://en.wikipedia.org/wiki/Tombstone_(data_store))) to a compacted topic used to `TableView`, the `TableView` should remove this key, but in the current implementation will throw an NPE and the `TableView` will stop reading the message.
   
   ConcurrentHashMap:
   ```java
       final V putVal(K key, V value, boolean onlyIfAbsent) {
           if (key == null || value == null) throw new NullPointerException();
   ```
   
   ### Modifications
   
   * Fix TableView handles null value messages.
   * Add unit test to cover this case.
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [x] `doc-not-needed` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] merlimat merged pull request #15951: [fix][client] Fix NPE when TableView handles null value message

Posted by GitBox <gi...@apache.org>.
merlimat merged PR #15951:
URL: https://github.com/apache/pulsar/pull/15951


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org