[GitHub] [spark] cloud-fan commented on a change in pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31348:
URL: https://github.com/apache/spark/pull/31348#discussion_r571844600



##########
File path: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
##########
@@ -750,6 +750,36 @@ private[deploy] class Worker(
     }
   }
 
+  /**
+   * Send `ExecutorStateChanged` to the current master. Unlike `sendToMaster`, we use `askSync`
+   * to send the message in order to ensure Master can receive the message.
+   */
+  private def syncExecutorStateWithMaster(newState: ExecutorStateChanged): Unit = {
+    master match {
+      case Some(masterRef) =>
+        try {
+          // SPARK-34245: We use async `send` to send the state previously. In that case, the

Review comment:
       we used




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org