You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by holdenk <gi...@git.apache.org> on 2017/10/10 20:12:01 UTC

[GitHub] spark pull request #15670: [SPARK-18161] [Python] Allow pickle to serialize ...

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15670#discussion_r143838765
  
    --- Diff: python/pyspark/serializers.py ---
    @@ -64,7 +64,7 @@
         from itertools import izip as zip
     else:
         import pickle
    -    protocol = 3
    +    protocol = min(pickle.HIGHEST_PROTOCOL, 4)
    --- End diff --
    
    It sounds like this part of the change would be ok then since Pyrolite can read v4 just fine.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org