[GitHub] [skywalking-nodejs] zijin-m edited a comment on pull request #29: add plugin mysql

[GitBox <gi...@apache.org>]

zijin-m edited a comment on pull request #29:
URL: https://github.com/apache/skywalking-nodejs/pull/29#issuecomment-785533692


   > > In addition, use the `resolve` package to read `package.json` because `mysql2` does not export the file `package.json`
   > 
   > What do you mean by "does not export"? It HAS a `package.json`.
   
   I'm sorry my description is not clear enough, I have updated it.
   According to the node documentation [modules](https://nodejs.org/api/esm.html#esm_subpath_exports) 
   
   ``` Bare specifiers like 'some-package' or 'some-package/shuffle'. They can refer to the main entry point of a package by the package name, or a specific feature module within a package prefixed by the package name as per the examples respectively. Including the file extension is only necessary for packages without an "exports" field.```
   
    while `mysql2` defines the `exports` field in its  [package.json](https://github.com/sidorares/node-mysql2/blob/master/package.json#L45) file, similar to [issue](https://github.com/react-native-community/cli/issues/1168#issuecomment-628034263) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org