[GitHub] [airflow] potiuk commented on pull request #17342: From feature request #17314: add support to enable kinit options [-f|-F] and [-a|-A]

[GitBox <gi...@apache.org>]

potiuk commented on pull request #17342:
URL: https://github.com/apache/airflow/pull/17342#issuecomment-889939682


   If all the tests pass, I think the change should be safe - but this might be a good opportunity to live the world a little better after the change than it was before :).
   
   Happy to guide you. I think we do not have (historically) a lot of tests about kerberos, but this might be a nice opportunity to add some unit tests to "renew_kt" function. Also it might be a nice opportunity to review and improve kerberos integration documentation - which might need some polishing (or even adding).
   
    Would you like to try ?
   
   It is a bit involved and requires to learn about mocking (but I can point you to a few examples that you can learn from). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org