[GitHub] [accumulo] ctubbsii commented on a change in pull request #2021: Minor java improvements

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2021:
URL: https://github.com/apache/accumulo/pull/2021#discussion_r613472469



##########
File path: core/src/main/java/org/apache/accumulo/core/client/summary/CountingSummarizer.java
##########
@@ -238,13 +238,11 @@ private void incrementCounter(K counter) {
           if (counters.size() >= maxCounters) {
             // no need to store this counter in the map and get() it... just use instance variable
             tooMany++;
+          } else // we have never seen this key before, check if its too long
+          if (encoder.apply(counter).length() >= maxCounterKeyLen) {

Review comment:
       ```suggestion
             } else if (encoder.apply(counter).length() >= maxCounterKeyLen) {
               // we have never seen this key before, check if its too long
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org