You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2014/03/29 02:03:19 UTC

Review Request 19813: [SENTRY-163] Fix CHANGELOG.txt in sentry 1.3.0 release branch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19813/
-----------------------------------------------------------

Review request for sentry, Brock Noland, Prasad Mujumdar, and Shreepadma Venugopalan.


Repository: sentry


Description
-------

[SENTRY-163] Fix CHANGELOG.txt in sentry 1.3.0 release branch


Diffs
-----

  CHANGELOG.txt 759ea942ef78a4ea315535732a1c35590c0b6bec 

Diff: https://reviews.apache.org/r/19813/diff/


Testing
-------

Trivial patch


Thanks,

Sravya Tirukkovalur


Re: Review Request 19813: [SENTRY-163] Fix CHANGELOG.txt in sentry 1.3.0 release branch

Posted by Sravya Tirukkovalur <sr...@cloudera.com>.

> On March 29, 2014, 1:07 a.m., Shreepadma Venugopalan wrote:
> > I glanced but didn't do an exhaustive verification.

I basically copied it over from here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12325060&styleName=Text&projectId=12314720&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7Cd092caf00ac0046f1774e388e4a2e56fbd47865d%7Clin . Hope that's the right thing to do?


- Sravya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19813/#review38975
-----------------------------------------------------------


On March 29, 2014, 1:03 a.m., Sravya Tirukkovalur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19813/
> -----------------------------------------------------------
> 
> (Updated March 29, 2014, 1:03 a.m.)
> 
> 
> Review request for sentry, Brock Noland, Prasad Mujumdar, and Shreepadma Venugopalan.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> [SENTRY-163] Fix CHANGELOG.txt in sentry 1.3.0 release branch
> 
> 
> Diffs
> -----
> 
>   CHANGELOG.txt 759ea942ef78a4ea315535732a1c35590c0b6bec 
> 
> Diff: https://reviews.apache.org/r/19813/diff/
> 
> 
> Testing
> -------
> 
> Trivial patch
> 
> 
> Thanks,
> 
> Sravya Tirukkovalur
> 
>


Re: Review Request 19813: [SENTRY-163] Fix CHANGELOG.txt in sentry 1.3.0 release branch

Posted by Shreepadma Venugopalan <sh...@cloudera.com>.

> On March 29, 2014, 1:07 a.m., Shreepadma Venugopalan wrote:
> > I glanced but didn't do an exhaustive verification.
> 
> Sravya Tirukkovalur wrote:
>     I basically copied it over from here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12325060&styleName=Text&projectId=12314720&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7Cd092caf00ac0046f1774e388e4a2e56fbd47865d%7Clin . Hope that's the right thing to do?

Should be good. I'd run a JIRA query to make sure all the fixed JIRAs have a version set.


- Shreepadma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19813/#review38975
-----------------------------------------------------------


On March 29, 2014, 1:03 a.m., Sravya Tirukkovalur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19813/
> -----------------------------------------------------------
> 
> (Updated March 29, 2014, 1:03 a.m.)
> 
> 
> Review request for sentry, Brock Noland, Prasad Mujumdar, and Shreepadma Venugopalan.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> [SENTRY-163] Fix CHANGELOG.txt in sentry 1.3.0 release branch
> 
> 
> Diffs
> -----
> 
>   CHANGELOG.txt 759ea942ef78a4ea315535732a1c35590c0b6bec 
> 
> Diff: https://reviews.apache.org/r/19813/diff/
> 
> 
> Testing
> -------
> 
> Trivial patch
> 
> 
> Thanks,
> 
> Sravya Tirukkovalur
> 
>


Re: Review Request 19813: [SENTRY-163] Fix CHANGELOG.txt in sentry 1.3.0 release branch

Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19813/#review38975
-----------------------------------------------------------

Ship it!


I glanced but didn't do an exhaustive verification.

- Shreepadma Venugopalan


On March 29, 2014, 1:03 a.m., Sravya Tirukkovalur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19813/
> -----------------------------------------------------------
> 
> (Updated March 29, 2014, 1:03 a.m.)
> 
> 
> Review request for sentry, Brock Noland, Prasad Mujumdar, and Shreepadma Venugopalan.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> [SENTRY-163] Fix CHANGELOG.txt in sentry 1.3.0 release branch
> 
> 
> Diffs
> -----
> 
>   CHANGELOG.txt 759ea942ef78a4ea315535732a1c35590c0b6bec 
> 
> Diff: https://reviews.apache.org/r/19813/diff/
> 
> 
> Testing
> -------
> 
> Trivial patch
> 
> 
> Thanks,
> 
> Sravya Tirukkovalur
> 
>