[GitHub] [lucene-solr] chatman removed a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

[GitBox <gi...@apache.org>]

chatman removed a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686320915


   > Yeah, the solution to API surface area problem is to make them inner classes/interfaces. This is such a elegant & simple proposition. We should try the same in other places in Solr where there is a surface area problem.
   
   Totally disagree, @noblepaul. I hope you're not serious here. Having getter methods like getFreeDiskSpace() etc. are better than having a FreeDiskProperty class, no matter it is inner or outer. Imagine the 100s (possibly 1000s) of different metrics/properties that would end up as inner classes with such a design!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org