You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Giovani Seben (JIRA)" <ji...@apache.org> on 2009/07/01 22:30:06 UTC

[jira] Created: (AMQ-2314) tmp_storage is not clean up once a slow subscriber is disconnected.

tmp_storage is not clean up once a slow subscriber is disconnected.
-------------------------------------------------------------------

                 Key: AMQ-2314
                 URL: https://issues.apache.org/activemq/browse/AMQ-2314
             Project: ActiveMQ
          Issue Type: Bug
    Affects Versions: 5.2.0, 5.3.0
            Reporter: Giovani Seben


With a producer sending messages to a topic with a slow subscriber, and messages accumulating under the tmp_storage, if the consumer is disconnected messages pushed to tmp_storage are not cleaned up by the broker.

I have a test case for this issue which I'll clean up and attach here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-2314) tmp_storage is not clean up once a slow subscriber is disconnected.

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully resolved AMQ-2314.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 5.4.0

pending messages are now removed when a sub is removed allowing the temp store to be reclaimed. Issue with memory usage management for pending messages spooled to disk list and retrieved is also resolved. 

> tmp_storage is not clean up once a slow subscriber is disconnected.
> -------------------------------------------------------------------
>
>                 Key: AMQ-2314
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2314
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.2.0, 5.3.0
>            Reporter: Giovani Seben
>            Assignee: Gary Tully
>             Fix For: 5.4.0
>
>
> With a producer sending messages to a topic with a slow subscriber, and messages accumulating under the tmp_storage, if the consumer is disconnected messages pushed to tmp_storage are not cleaned up by the broker.
> I have a test case for this issue which I'll clean up and attach here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2314) tmp_storage is not clean up once a slow subscriber is disconnected.

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=54826#action_54826 ] 

Gary Tully commented on AMQ-2314:
---------------------------------

Giovani, do you have a test case or xml configuration that you use to reproduce this?

> tmp_storage is not clean up once a slow subscriber is disconnected.
> -------------------------------------------------------------------
>
>                 Key: AMQ-2314
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2314
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.2.0, 5.3.0
>            Reporter: Giovani Seben
>            Assignee: Gary Tully
>
> With a producer sending messages to a topic with a slow subscriber, and messages accumulating under the tmp_storage, if the consumer is disconnected messages pushed to tmp_storage are not cleaned up by the broker.
> I have a test case for this issue which I'll clean up and attach here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2314) tmp_storage is not clean up once a slow subscriber is disconnected.

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=54794#action_54794 ] 

Gary Tully commented on AMQ-2314:
---------------------------------

just a hunch, but it looks like the order of super.clear() in org.apache.activemq.kaha.impl.container.ListContainerImpl.clear() could be the problem here. A test case would help of course. Think the super.clear whacks the index and the local doClear has nothing to do.

> tmp_storage is not clean up once a slow subscriber is disconnected.
> -------------------------------------------------------------------
>
>                 Key: AMQ-2314
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2314
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.2.0, 5.3.0
>            Reporter: Giovani Seben
>
> With a producer sending messages to a topic with a slow subscriber, and messages accumulating under the tmp_storage, if the consumer is disconnected messages pushed to tmp_storage are not cleaned up by the broker.
> I have a test case for this issue which I'll clean up and attach here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2314) tmp_storage is not clean up once a slow subscriber is disconnected.

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=54941#action_54941 ] 

Gary Tully commented on AMQ-2314:
---------------------------------

last thought, validate that the test case I used meets your requirements, see activemq-core/src/test/java/org/apache/activemq/bugs/AMQ2314Test.java 
The test verify the temp store usage increased and decreased as expected. Note, some temp store usage increase is expected, till an in use file is no longer referenced (the current write file cannot be removed), but long term use will be steady.

> tmp_storage is not clean up once a slow subscriber is disconnected.
> -------------------------------------------------------------------
>
>                 Key: AMQ-2314
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2314
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.2.0, 5.3.0
>            Reporter: Giovani Seben
>            Assignee: Gary Tully
>             Fix For: 5.4.0
>
>
> With a producer sending messages to a topic with a slow subscriber, and messages accumulating under the tmp_storage, if the consumer is disconnected messages pushed to tmp_storage are not cleaned up by the broker.
> I have a test case for this issue which I'll clean up and attach here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2314) tmp_storage is not clean up once a slow subscriber is disconnected.

Posted by "James Casey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=54943#action_54943 ] 

James Casey commented on AMQ-2314:
----------------------------------

Gary,

I looked at the logic in the test case and it makes sense for the problem we saw.

I'll try a snapshot build on monday and check the fix is ok.

cheers,

James

> tmp_storage is not clean up once a slow subscriber is disconnected.
> -------------------------------------------------------------------
>
>                 Key: AMQ-2314
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2314
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.2.0, 5.3.0
>            Reporter: Giovani Seben
>            Assignee: Gary Tully
>             Fix For: 5.4.0
>
>
> With a producer sending messages to a topic with a slow subscriber, and messages accumulating under the tmp_storage, if the consumer is disconnected messages pushed to tmp_storage are not cleaned up by the broker.
> I have a test case for this issue which I'll clean up and attach here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (AMQ-2314) tmp_storage is not clean up once a slow subscriber is disconnected.

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully reassigned AMQ-2314:
-------------------------------

    Assignee: Gary Tully

> tmp_storage is not clean up once a slow subscriber is disconnected.
> -------------------------------------------------------------------
>
>                 Key: AMQ-2314
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2314
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.2.0, 5.3.0
>            Reporter: Giovani Seben
>            Assignee: Gary Tully
>
> With a producer sending messages to a topic with a slow subscriber, and messages accumulating under the tmp_storage, if the consumer is disconnected messages pushed to tmp_storage are not cleaned up by the broker.
> I have a test case for this issue which I'll clean up and attach here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.