[GitHub] [airflow] pankajastro commented on a diff in pull request #30166: Update usage of accept_none arg in SQLColumn/TableCheckOperators

["pankajastro (via GitHub)" <gi...@apache.org>]

pankajastro commented on code in PR #30166:
URL: https://github.com/apache/airflow/pull/30166#discussion_r1160916919


##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -585,41 +622,70 @@ def __init__(
         partition_clause: str | None = None,
         conn_id: str | None = None,
         database: str | None = None,
+        accept_none: bool = True,

Review Comment:
   before these changes, when a query was returning None the task was failing, by setting  `accept_none` default value to true I think will change the old behaviour i.e now a task may not fail. do we need to worry about backward compatibility and maybe set this false by default, wdyt? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org