You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/02/12 08:19:09 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #3700: Sliceable BitMap
viirya opened a new pull request, #3700:
URL: https://github.com/apache/arrow-rs/pull/3700
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1802.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya closed pull request #3700: Sliceable BitMap
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya closed pull request #3700: Sliceable BitMap
URL: https://github.com/apache/arrow-rs/pull/3700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #3700: Sliceable BitMap
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #3700:
URL: https://github.com/apache/arrow-rs/pull/3700#issuecomment-1437818222
Yea, if you have also looked at my previous PR (closed) for this, it involved more code change. Almost everywhere we currently return null buffer/bitmap and access it needs to be changed. So opened this one to try to have less change if possible.
Seems a good idea to be a new type for it. I will try it in the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3700: Sliceable BitMap
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3700:
URL: https://github.com/apache/arrow-rs/pull/3700#issuecomment-1438759278
I plan to add a `BooleanBuffer` type as part of #1176 which should fit this use-case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3700: Sliceable BitMap
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3700:
URL: https://github.com/apache/arrow-rs/pull/3700#issuecomment-1437128292
I wonder if this needs to be a new type, there is a non-trivial amount of code that has an implicit assumption that Bitmap is just a wrapper around a `Buffer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #3700: Sliceable BitMap
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #3700:
URL: https://github.com/apache/arrow-rs/pull/3700#issuecomment-1445794941
Close in favor of #3749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org