You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/11/30 17:06:30 UTC
[PR] HDDS-11822. Register subcommands in OzoneShell [ozone]
adoroszlai opened a new pull request, #7513:
URL: https://github.com/apache/ozone/pull/7513
## What changes were proposed in this pull request?
`OzoneShell` subcommands are currently added via `ServiceLoader` (by implementing `SubcommandWithParent`). Since this is a well-defined set of commands, we can register them in the parent command directly (`subcommands = { ... }`).
https://issues.apache.org/jira/browse/HDDS-11822
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/12096565592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11822. Register subcommands in OzoneShell [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7513:
URL: https://github.com/apache/ozone/pull/7513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11822. Register subcommands in OzoneShell [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7513:
URL: https://github.com/apache/ozone/pull/7513#issuecomment-2511344369
Thanks @sodonnel for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org