[GitHub] [druid] abhishekagarwal87 commented on pull request #12418: Handling planning with alias for time for group by and order by

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on PR #12418:
URL: https://github.com/apache/druid/pull/12418#issuecomment-1094228130

   > the check in the scan query allows group by only on the __time column
   
   Did you mean to say that scan query allows order by only on the __time column? What if we ignore erroneous plans during planning? So we could changes `DruidRules` class to something like below
   ```
            if (outerQueryRel.isValidDruidQuery()) {
   -          call.transformTo(outerQueryRel);
   +          try {
   +            call.transformTo(outerQueryRel);
   +          } catch (Exception ex) {
   +            if (Throwables.getCauseOfType(ex, CannotBuildQueryException.class) == null) {
   +              throw ex;
   +            }
   +            // Do nothing
   +          }
            }
          }
   ```
   
   I tested the query with above change and it plans successfully. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org