You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by vi...@apache.org on 2015/06/17 01:25:51 UTC

mesos git commit: Removed unused drop(...) overload in scheduler library.

Repository: mesos
Updated Branches:
  refs/heads/master 4b6b03f1d -> fa0d564a9


Removed unused drop(...) overload in scheduler library.

The library (src/scheduler/scheduler.cpp) already does the right thing
of not doing anything and just dropping requests when it is
disconnected from the master. This change just deletes the unused
overload that is no longer being used.

Review: https://reviews.apache.org/r/35538


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/fa0d564a
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/fa0d564a
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/fa0d564a

Branch: refs/heads/master
Commit: fa0d564a9fd813d51917d21daaf25fe34c4154ee
Parents: 4b6b03f
Author: Anand Mazumdar <ma...@gmail.com>
Authored: Tue Jun 16 16:24:46 2015 -0700
Committer: Vinod Kone <vi...@gmail.com>
Committed: Tue Jun 16 16:24:47 2015 -0700

----------------------------------------------------------------------
 src/scheduler/scheduler.cpp | 18 ------------------
 1 file changed, 18 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/fa0d564a/src/scheduler/scheduler.cpp
----------------------------------------------------------------------
diff --git a/src/scheduler/scheduler.cpp b/src/scheduler/scheduler.cpp
index af18c6b..1efc6fb 100644
--- a/src/scheduler/scheduler.cpp
+++ b/src/scheduler/scheduler.cpp
@@ -703,24 +703,6 @@ protected:
     receive(None(), event);
   }
 
-  // Helper for "dropping" a task that was launched.
-  void drop(const TaskInfo& task, const string& message)
-  {
-    Event event;
-
-    event.set_type(Event::UPDATE);
-
-    Event::Update* update = event.mutable_update();
-
-    TaskStatus* status = update->mutable_status();
-    status->mutable_task_id()->CopyFrom(task.task_id());
-    status->set_state(TASK_LOST);
-    status->set_message(message);
-    status->set_timestamp(Clock::now().secs());
-
-    receive(None(), event);
-  }
-
   void drop(const Call& call, const string& message)
   {
     LOG(WARNING) << "Dropping " << call.type() << ": " << message;