[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2260: HDDS-5241. SCM UI should have leader/follower and Primordial SCM information

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2260:
URL: https://github.com/apache/ozone/pull/2260#discussion_r636005382



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -1708,4 +1708,17 @@ ContainerTokenSecretManager getContainerTokenSecretManager() {
     return containerTokenMgr;
   }
 
+  @Override
+  public List<String> getScmRatisRoles() throws IOException {
+    return getScmHAManager().getRatisServer().getRatisRoles();

Review comment:
       Port looks too general, can we specifically mention ratis port?
   As SCM has multiple RPC endpoints.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org