[GitHub] WillemJiang commented on a change in pull request #534: SCB-293 sleep before quering in tracing test

[GitBox <gi...@apache.org>]

WillemJiang commented on a change in pull request #534: SCB-293 sleep before quering in tracing test
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/534#discussion_r164286913
 
 

 ##########
 File path: integration-tests/test-common/src/test/java/org/apache/servicecomb/tests/tracing/TracingTestBase.java
 ##########
 @@ -75,6 +75,15 @@ protected void assertThatSpansReceivedByZipkin(Collection<String> logs, String..
         .map(this::extractIds)
         .collect(Collectors.toList());
 
+    // Sleep for 5 seconds to wait the reporter finish posting to zipkin server.
 
 Review comment:
   Using the wait and try look up span id could be a reasonable way for checking the async report result.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services