You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2022/04/16 16:25:00 UTC

[jira] [Comment Edited] (MJAVADOC-700) Plugin duplicates classes in Java 8 all-classes lists

    [ https://issues.apache.org/jira/browse/MJAVADOC-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523140#comment-17523140 ] 

Michael Osipov edited comment on MJAVADOC-700 at 4/16/22 4:24 PM:
------------------------------------------------------------------

I can confirm this:
{noformat}
commit 55982df63f8de5bfbb48aee353bc29b35b1c6a2c
Author: rfscholte <rf...@apache.org>
Date:   Mon May 17 22:50:04 2021 +0200

    [MJAVADOC-584] excludePackageNames is not working as documented anymore
{noformat}

[~rfscholte], WDYT?

I am currently evaluating

{noformat}
diff --git a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
index 0e5eda01..3f9cb2b5 100644
--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
@@ -379,7 +379,7 @@ public class JavadocUtil

             if ( !excluded )
             {
-                files.add( file.replace( '\\', '/' ) );
+                files.add( file.replace( '\\', File.separatorChar ) );
             }
         }
{noformat}


was (Author: michael-o):
I can confirm this:
{noformat}
commit 55982df63f8de5bfbb48aee353bc29b35b1c6a2c
Author: rfscholte <rf...@apache.org>
Date:   Mon May 17 22:50:04 2021 +0200

    [MJAVADOC-584] excludePackageNames is not working as documented anymore
{noformat}

[~rfscholte], WDYT?

I am currently evaluating

{noformat}
diff --git a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
index 0e5eda01..3f9cb2b5 100644
--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
@@ -379,7 +379,7 @@ public class JavadocUtil

             if ( !excluded )
             {
-                files.add( file.replace( '\\', '/' ) );
+                files.add( file.replace( '\\', File.separatorChar ) );^M
             }
         }
{noformat}

> Plugin duplicates classes in Java 8 all-classes  lists
> ------------------------------------------------------
>
>                 Key: MJAVADOC-700
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-700
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>    Affects Versions: 3.3.0, 3.3.1
>            Reporter: Rob Spoor
>            Priority: Major
>
> Versions 3.3.0 and 3.3.1 of the Javadoc Plugin create allclasses-frame.html and allclasses-noframe.html files that duplicate all classes, interfaces, etc.
> To reproduce:
> * Clone https://github.com/robtimus/data-url (a simple and small project that can be used to showcase the issue)
> * Run {{mvn javadoc:javadoc}}, which uses version 3.2.0
> * Check target/site/apidocs/allclasses-frame.html - no duplicates
> * Run {{mvn javadoc:javadoc -Dversion.plugin.javadoc=3.3.0}} to build the same with version 3.3.0
> * Check target/site/apidocs/allclasses-frame.html - all classes are duplicated
> The same issue occurs with {{javadoc:aggregate}}, possibly others as well.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)