You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Jim Apple (JIRA)" <ji...@apache.org> on 2018/09/30 04:12:00 UTC

[jira] [Commented] (IMPALA-3675) consider turning -Werror on for release and address sanitizer builds

    [ https://issues.apache.org/jira/browse/IMPALA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633218#comment-16633218 ] 

Jim Apple commented on IMPALA-3675:
-----------------------------------

We can turn on just one warning as an error using flags like {{-Werror=array-bounds}} to turn warnings from {{-Warray-bounds}} into errors.

> consider turning -Werror on for release and address sanitizer builds
> --------------------------------------------------------------------
>
>                 Key: IMPALA-3675
>                 URL: https://issues.apache.org/jira/browse/IMPALA-3675
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>    Affects Versions: Impala 2.6.0
>            Reporter: Silvius Rus
>            Priority: Minor
>              Labels: newbie, static-analysis
>
> Currently it seems we're only using -Werror with debug builds.
> The problem is that a number of GCC warnings get issued by the analysis/transformation at -O2 or higher.  So there could be warnings in our release builds that we're simply ignoring.
> We should consider turning -Werror on in release builds.  Perhaps have another "static-analysis" target that does something like this (and use it in GVMs and recommend before submitting code reviews):
> {code}
> g++ ${CXX_FLAGS_RELEASE} -fsyntax-only -Werror -Wfatal-errors ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org