You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/27 09:42:25 UTC
[GitHub] [apisix] panhow opened a new pull request, #8575: feature: support configure http listen backlog in config
panhow opened a new pull request, #8575:
URL: https://github.com/apache/apisix/pull/8575
### Description
feature: support configure http listen backlog in config
Fixes # (issue)]
#8055
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] panhow commented on pull request #8575: feat: support configure http listen backlog in config
Posted by GitBox <gi...@apache.org>.
panhow commented on PR #8575:
URL: https://github.com/apache/apisix/pull/8575#issuecomment-1365763981
@tzssangglass PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on pull request #8575: feat: support configure http listen backlog in config
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8575:
URL: https://github.com/apache/apisix/pull/8575#issuecomment-1595698476
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed pull request #8575: feat: support configure http listen backlog in config
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8575: feat: support configure http listen backlog in config
URL: https://github.com/apache/apisix/pull/8575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #8575: feat: support configure http listen backlog in config
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #8575:
URL: https://github.com/apache/apisix/pull/8575#discussion_r1058737095
##########
conf/config-default.yaml:
##########
@@ -28,6 +28,7 @@ apisix:
# - ip: 127.0.0.2 # Specific IP, If not set, the default value is `0.0.0.0`.
# port: 9082
# enable_http2: true
+ # listen_backlog: 511 # Sets nginx listen backlog.If not set, the default value is `511`. http://nginx.org/en/docs/http/ngx_http_core_module.html#listen
Review Comment:
Like `enable_http2`, it would be better to make the `listen_backlog` as a per-listen configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] panhow commented on pull request #8575: feat: support configure http listen backlog in config
Posted by GitBox <gi...@apache.org>.
panhow commented on PR #8575:
URL: https://github.com/apache/apisix/pull/8575#issuecomment-1366555998
> Please make the CI pass, thanks!
how to trigger CI again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on pull request #8575: feat: support configure http listen backlog in config
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8575:
URL: https://github.com/apache/apisix/pull/8575#issuecomment-1551109938
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #8575: feat: support configure http listen backlog in config
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #8575:
URL: https://github.com/apache/apisix/pull/8575#discussion_r1058691169
##########
t/cli/test_main.sh:
##########
@@ -55,6 +55,33 @@ fi
echo "passed: nginx.conf file contains reuseport configuration"
+# check default listen_backlog
+
+! grep -E "listen .* backlog=" conf/nginx.conf > /dev/null
+if [ ! $? -eq 0 ]; then
+ echo "failed: nginx.conf file contains backlog configuration"
+ exit 1
+fi
+
+echo "passed: nginx.conf file default backlog configuration"
+
+# check sets listen_backlog
+echo "
+apisix:
+ listen_backlog: 1023
+
+" > conf/config.yaml
+
+make init
+
+count_http_backlog=`grep -Ec "listen .* backlog=" conf/nginx.conf`
Review Comment:
```
count_http_backlog=`grep -Ec "listen .* backlog=1023" conf/nginx.conf`
```
is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] panhow commented on a diff in pull request #8575: feat: support configure http listen backlog in config
Posted by GitBox <gi...@apache.org>.
panhow commented on code in PR #8575:
URL: https://github.com/apache/apisix/pull/8575#discussion_r1058710690
##########
t/cli/test_main.sh:
##########
@@ -55,6 +55,33 @@ fi
echo "passed: nginx.conf file contains reuseport configuration"
+# check default listen_backlog
+
+! grep -E "listen .* backlog=" conf/nginx.conf > /dev/null
+if [ ! $? -eq 0 ]; then
+ echo "failed: nginx.conf file contains backlog configuration"
+ exit 1
+fi
+
+echo "passed: nginx.conf file default backlog configuration"
+
+# check sets listen_backlog
+echo "
+apisix:
+ listen_backlog: 1023
+
+" > conf/config.yaml
+
+make init
+
+count_http_backlog=`grep -Ec "listen .* backlog=" conf/nginx.conf`
Review Comment:
ya， this would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #8575: feat: support configure http listen backlog in config
Posted by GitBox <gi...@apache.org>.
spacewander commented on PR #8575:
URL: https://github.com/apache/apisix/pull/8575#issuecomment-1366382839
Please make the CI pass, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org