Re: Review Request 53857: GEODE-2095: Stabilize flaky tests

[anilkumar gingade <ag...@pivotal.io>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53857/#review157787
-----------------------------------------------------------


Ship it!




Ship It!

- anilkumar gingade


On Nov. 17, 2016, 10:38 p.m., Ken Howe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53857/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2016, 10:38 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Eric Shu.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Changed checks for expected log messages from time based to event based.
> 
> Tests that verify that log messages occured as expected were using an overly optimistic test for 'n'
> logs after a set period of time. The Mockito.verify calls are now placed within the swait()'s. Also simplified tests that have a final check to make sure missing colocated region logging stopped after all child PRs are created.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java a044a612fbbc6b905e3ad1389a9c0d7994f8598a 
> 
> Diff: https://reviews.apache.org/r/53857/diff/
> 
> 
> Testing
> -------
> 
> Ran spotlessCheck (and spotlessApply to fix some formatting)
> 
> Precheckin copmleted successfully
> 
> 
> Thanks,
> 
> Ken Howe
> 
>