svn commit: r565834 - /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java

[aw...@apache.org]

Author: awiner
Date: Tue Aug 14 09:52:05 2007
New Revision: 565834

URL: http://svn.apache.org/viewvc?view=rev&rev=565834
Log:
Add TODOs for rest of TRINIDAD-96

Modified:
    myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java

Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java?view=diff&rev=565834&r1=565833&r2=565834
==============================================================================
--- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java (original)
+++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java Tue Aug 14 09:52:05 2007
@@ -435,6 +435,31 @@
 
 
   // Renders validation code
+  // Code is of the form:
+  //  - Dependencies, written sequentially
+  //  - _Validations array (an array of stringified JSON objects)
+  //      (TODO: stringifying these is mostly pointless)
+  //  - _Validators array, which is an array of 5*N entries with each 5:
+  //     0: clientId,
+  //     1: required (0 or 1)
+  //     2: requiredFormatIndex (blank if required==0) - index into _Formats
+  //     3: converter (or (void 0) if omitted) - index into Validations array
+  //     4: validator array - array of integers, each index into Validations
+  //     TODO: turn into a Map of clientId to 4 entries
+  //  - Validator function:
+  //     TODO: don't render for PPR.
+  //     TODO: don't pass index of global message format - just pass the message
+  //          and delete addGlobalMessageFormat() API
+  //  - Label map: clientId to label
+  //     TODO: inline into Validators array
+  //  - _Formats array: now used only for required messages + "global"
+  //  TODO:
+  //    Make one monster function of the form:
+  //   TrPage.prototype._addValidators(
+  //      components (Map of clientId -> other info)
+  //      validationsArray,
+  //      formatsArray,
+  //
   private static void _renderValidationScripts(
     FacesContext        context,
     RenderingContext arc