You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dag H. Wanvik (JIRA)" <ji...@apache.org> on 2012/06/12 20:24:42 UTC
[jira] [Created] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Dag H. Wanvik created DERBY-5814:
------------------------------------
Summary: Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
Key: DERBY-5814
URL: https://issues.apache.org/jira/browse/DERBY-5814
Project: Derby
Issue Type: Improvement
Reporter: Dag H. Wanvik
Attachments: catalog-compile-cleaning.diff
A patch which clean up sources as follows:
a) removed unused private methods
b) removed unused local variables and members
c) cleaned up imports
d) remove unused formal arguments
A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik reassigned DERBY-5814:
------------------------------------
Assignee: Dag H. Wanvik
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295089#comment-13295089 ]
Dag H. Wanvik edited comment on DERBY-5814 at 6/14/12 3:17 PM:
---------------------------------------------------------------
Uploading version 2 with Knut's suggestion plus some further whitespace cleanups (only in those lines I touched anyway).
was (Author: dagw):
Uploading version 2 with Knut's suggestion plus some further whitespace cleanups.
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.10.0.0
>
> Attachments: catalog-compile-cleaning-2.diff, catalog-compile-cleaning-2.stat, catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295095#comment-13295095 ]
Dag H. Wanvik commented on DERBY-5814:
--------------------------------------
Tan the VTI tests over again, committed as svn 1350289, closing.
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.10.0.0
>
> Attachments: catalog-compile-cleaning-2.diff, catalog-compile-cleaning-2.stat, catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik closed DERBY-5814.
--------------------------------
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Trivial
> Fix For: 10.10.0.0
>
> Attachments: catalog-compile-cleaning-2.diff, catalog-compile-cleaning-2.stat, catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5814:
---------------------------------
Attachment: catalog-compile-cleaning-2.stat
catalog-compile-cleaning-2.diff
Uploading version 2 with Knut's suggestion plus some further whitespace cleanups.
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: catalog-compile-cleaning-2.diff, catalog-compile-cleaning-2.stat, catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295095#comment-13295095 ]
Dag H. Wanvik edited comment on DERBY-5814 at 6/14/12 3:17 PM:
---------------------------------------------------------------
Ran the VTI tests over again, committed as svn 1350289, closing.
was (Author: dagw):
Tan the VTI tests over again, committed as svn 1350289, closing.
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.10.0.0
>
> Attachments: catalog-compile-cleaning-2.diff, catalog-compile-cleaning-2.stat, catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5814:
---------------------------------
Issue & fix info: Patch Available
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Reporter: Dag H. Wanvik
> Attachments: catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295078#comment-13295078 ]
Dag H. Wanvik commented on DERBY-5814:
--------------------------------------
Thanks, Knut! Yup, I'll do that.
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294352#comment-13294352 ]
Knut Anders Hatlen commented on DERBY-5814:
-------------------------------------------
Looks like a good cleanup.
FromVTI.markUpdatableByCursor() now only forwards to its super class. Remove and rely on inheritance?
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik resolved DERBY-5814.
----------------------------------
Resolution: Fixed
Fix Version/s: 10.10.0.0
Issue & fix info: (was: Patch Available)
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.10.0.0
>
> Attachments: catalog-compile-cleaning-2.diff, catalog-compile-cleaning-2.stat, catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5814:
---------------------------------
Component/s: SQL
Priority: Trivial (was: Major)
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Trivial
> Fix For: 10.10.0.0
>
> Attachments: catalog-compile-cleaning-2.diff, catalog-compile-cleaning-2.stat, catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5814) Source cleanup in catalogs
"impl.sql.catalog" and "impl.sql.compile"
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-5814:
---------------------------------
Attachment: catalog-compile-cleaning.diff
Regressions passed with these changes.
> Source cleanup in catalogs "impl.sql.catalog" and "impl.sql.compile"
> --------------------------------------------------------------------
>
> Key: DERBY-5814
> URL: https://issues.apache.org/jira/browse/DERBY-5814
> Project: Derby
> Issue Type: Improvement
> Reporter: Dag H. Wanvik
> Attachments: catalog-compile-cleaning.diff
>
>
> A patch which clean up sources as follows:
> a) removed unused private methods
> b) removed unused local variables and members
> c) cleaned up imports
> d) remove unused formal arguments
>
> A repercussion of a d) gave simplifications in sqlgrammar.jj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira